ixgbevf: Add error messages on vlan error
Subsystems (2)
PATCH v2 1/1 ixgbevf: Add error messages on vlan error
From: "Jan Sokolowski" <[email protected]>
ixgbevf did not provide an error in dmesg if VLAN addition failed.
Add two descriptive failure messages in the kernel log.
---
v2: Reworded commit message
.../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +12 -5
@@ -2044,12 +2044,16 @@ static int ixgbevf_vlan_rx_add_vid(struct net_device *netdev,spin_unlock_bh (&adapter->mbx_lock); -/* translate error return types so error makes sense */ -if (err ==IXGBE_ERR_MBX ) -return -EIO ; +if (err) { +netdev_err (netdev,"VF could not set VLAN %d\n" , vid); + +/* translate error return types so error makes sense */ +if (err ==IXGBE_ERR_MBX ) +return -EIO ; -if (err ==IXGBE_ERR_INVALID_ARGUMENT ) -return -EACCES ; +if (err ==IXGBE_ERR_INVALID_ARGUMENT ) +return -EACCES ; + }set_bit (vid, adapter->active_vlans);
@@ -2070,6 +2074,9 @@ static int ixgbevf_vlan_rx_kill_vid(struct net_device *netdev,spin_unlock_bh (&adapter->mbx_lock); +if (err) +netdev_err (netdev,"Could not remove VLAN %d\n" , vid); +clear_bit (vid, adapter->active_vlans);return err;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c static int ixgbevf_vlan_rx_add_vid(struct
Quoted 28 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Jan Sokolowski
Sent: Thursday, October 6, 2022 2:44 PM
To: [email protected]
Subject: [Intel-wired-lan] [PATCH net-next v2] ixgbevf: Add error messages on vlan errorFrom: "Jan Sokolowski" <[email protected]>
ixgbevf did not provide an error in dmesg if VLAN addition failed.
Add two descriptive failure messages in the kernel log.
Signed-off-by Jan Sokolowski <[email protected]>---
v2: Reworded commit message.../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +0
-0@@ -2044,12 +2044,16 @@ static int ixgbevf_vlan_rx_add_vid(struct
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan