ixgbevf: Add error messages on vlan error
Subsystems (2)
PATCH 1/1 ixgbevf: Add error messages on vlan error
From: "Sokolowski, Jan" <[email protected]>
ixgbevf did not provide an error in dmesg if VLAN
addition failed.
Add more descriptive failure messages in the kernel log.
--- .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +12 -5
@@ -2044,12 +2044,16 @@ static int ixgbevf_vlan_rx_add_vid(struct net_device *netdev,spin_unlock_bh (&adapter->mbx_lock); -/* translate error return types so error makes sense */ -if (err ==IXGBE_ERR_MBX ) -return -EIO ; +if (err) { +netdev_err (netdev,"VF could not set VLAN %d\n" , vid); + +/* translate error return types so error makes sense */ +if (err ==IXGBE_ERR_MBX ) +return -EIO ; -if (err ==IXGBE_ERR_INVALID_ARGUMENT ) -return -EACCES ; +if (err ==IXGBE_ERR_INVALID_ARGUMENT ) +return -EACCES ; + }set_bit (vid, adapter->active_vlans);
@@ -2070,6 +2074,9 @@ static int ixgbevf_vlan_rx_kill_vid(struct net_device *netdev,spin_unlock_bh (&adapter->mbx_lock); +if (err) +netdev_err (netdev,"Could not remove VLAN %d\n" , vid); +clear_bit (vid, adapter->active_vlans);return err;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-wired-lan mailing list [email protected] https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Dear Jan,
Thank you for your patch. Two nits.
Am 03.10.22 um 10:26 schrieb Jan Sokolowski:
Quoted 1 line
From: "Sokolowski, Jan" <[email protected]>
Please adapt your git configuration to use
Jan Sokolowski <[email protected]>
Quoted 2 lines
ixgbevf did not provide an error in dmesg if VLAN
addition failed.
This fits in one. line.
Quoted 1 line
Add more descriptive failure messages in the kernel log.
*more descriptive* is ambiguous, maybe just: Add two descriptive …?
[…]
Kind regards,
Paul
_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan