Skip to contentSkip to conversation

s390x: Add exit time test

PATCH Superseded Nico Boehr 2 participants 3 messages Oct 12, 2022 KVM

v3 of 7 Superseded Latest is v7 →

lore
Share & tools
lore

Nico Boehr

author
#0 lore raw

v3 cover s390x: Add exit time test

v2->v3:
---
* print average (thanks Claudio)
* have asm constraints look the same everywhere (thanks Claudio)
* rebase patchset on top of my migration sck patches[1] to make use of the time.h improvements

v1->v2:
---
* add missing cc clobber, fix constraints for get_clock_us() (thanks Thomas)
* avoid array and use pointer to const char* (thanks Thomas)
* add comment why testing nop makes sense (thanks Thomas)
* rework constraints and clobbers (thanks Thomas)

Sometimes, it is useful to measure the exit time of certain instructions to e.g. identify performance regressions in instructions emulated by the hypervisor.

This series adds a test which executes some instructions and measures their execution time. Since their execution time depends a lot on the environment at hand, all tests are reported as PASS currently.

The point of this series is not so much the instructions which have been chosen here (but your ideas are welcome), but rather the general question whether it makes sense to have a test like this in kvm-unit-tests.

This series is based on my migration sck patches[1] to make use of the time.h improvements there.

[1] https://lore.kernel.org/all/[email protected]/

Nico Boehr (1):
s390x: add exittime tests

 s390x/Makefile      |   1 +
 s390x/exittime.c    | 253 ++++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg |   5 +
 3 files changed, 259 insertions(+)
 create mode 100644 s390x/exittime.c
Signature · 1 line
2.36.1
author
#1 lore raw

PATCH v3 1/1 s390x: add exittime tests

Add a test to measure the execution time of several instructions. This can be helpful in finding performance regressions in hypervisor code.

All tests are currently reported as PASS, since the baseline for their execution time depends on the respective environment and since needs to be determined on a case-by-case basis.

---
 s390x/Makefile      |   1 +
 s390x/exittime.c    | 253 ++++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg |   5 +
 3 files changed, 259 insertions(+)
 create mode 100644 s390x/exittime.c
s390x/Makefile +1 -0
index fba09bc2df3a..a28c6746cf55 100644
@@ -37,6 +37,7 @@ tests += $(TEST_DIR)/migration-skey.elf
 tests += $(TEST_DIR)/panic-loop-extint.elf
 tests += $(TEST_DIR)/panic-loop-pgm.elf
 tests += $(TEST_DIR)/migration-sck.elf
+tests += $(TEST_DIR)/exittime.elf
 
 pv-tests += $(TEST_DIR)/pv-diags.elf
 
s390x/exittime.c new file +253 -0

253 lines not on this page · raw message

s390x/unittests.cfg +5 -0
index 2c04ae7c7c15..11cac3ca135d 100644
@@ -185,6 +185,7 @@ groups = migration
 [migration-skey]
 file = migration-skey.elf
 groups = migration
+<<<<<<< HEAD
 
 [panic-loop-extint]
 file = panic-loop-extint.elf
@@ -201,3 +202,7 @@ timeout = 5
 [migration-sck]
 file = migration-sck.elf
 groups = migration
+
+[exittime]
+file = exittime.elf
+smp = 2
Signature · 1 line
2.36.1
#2 lore raw

Re: [kvm-unit-tests PATCH v3 1/1] s390x: add exittime tests

Am 12.10.22 um 14:11 schrieb Nico Boehr:

s390x/unittests.cfg groups = migration · line 188

Quoted 9 lines
s390x/unittests.cfg +1 -0
index 2c04ae7c7c15..11cac3ca135d 100644
@@ -185,6 +185,7 @@ groups = migration
  [migration-skey]
  file = migration-skey.elf
  groups = migration
+<<<<<<< HEAD

looks like a wrong merge conflict leftover.