s390x: Add exit time test
v7 cover s390x: Add exit time test
v6->v7:
---
* change info message to indicate normalization and number of iterations normalized to (thanks Claudio)
v5->v6:
---
* multiply first, then divide when normalizing (thanks Claudio)
* print fractions of us (thanks Claudio)
* remove non-normalized output (thanks Claudio)
* fence dag9c since not supported under TCG
v4->v5:
---
* print normalized runtime to be able to compare runtime of instructions in a single run (thanks Claudio)
v3->v4:
---
* remove merge conflict markers (thanks Christian)
v2->v3:
---
* print average (thanks Claudio)
* have asm constraints look the same everywhere (thanks Claudio)
* rebase patchset on top of my migration sck patches[1] to make use of the time.h improvements
v1->v2:
---
* add missing cc clobber, fix constraints for get_clock_us() (thanks Thomas)
* avoid array and use pointer to const char* (thanks Thomas)
* add comment why testing nop makes sense (thanks Thomas)
* rework constraints and clobbers (thanks Thomas)
Sometimes, it is useful to measure the exit time of certain instructions to e.g. identify performance regressions in instructions emulated by the hypervisor.
This series adds a test which executes some instructions and measures their execution time. Since their execution time depends a lot on the environment at hand, all tests are reported as PASS currently.
The point of this series is not so much the instructions which have been chosen here (but your ideas are welcome), but rather the general question whether it makes sense to have a test like this in kvm-unit-tests.
This series is based on my migration sck patches[1] to make use of the time.h improvements there.
[1] https://lore.kernel.org/all/[email protected]/
Nico Boehr (1):
s390x: add exittime tests
s390x/Makefile | 1 + s390x/exittime.c | 296 ++++++++++++++++++++++++++++++++++++++++++++ s390x/unittests.cfg | 4 + 3 files changed, 301 insertions(+) create mode 100644 s390x/exittime.c
Signature · 1 line
2.36.1
PATCH v7 1/1 s390x: add exittime tests
Add a test to measure the execution time of several instructions. This can be helpful in finding performance regressions in hypervisor code.
All tests are currently reported as PASS, since the baseline for their execution time depends on the respective environment and since needs to be determined on a case-by-case basis.
--- s390x/Makefile | 1 + s390x/exittime.c | 296 ++++++++++++++++++++++++++++++++++++++++++++ s390x/unittests.cfg | 4 + 3 files changed, 301 insertions(+) create mode 100644 s390x/exittime.c
s390x/Makefile +1 -0
@@ -37,6 +37,7 @@ tests += $(TEST_DIR)/migration-skey.elf tests += $(TEST_DIR)/panic-loop-extint.elf tests += $(TEST_DIR)/panic-loop-pgm.elf tests += $(TEST_DIR)/migration-sck.elf +tests += $(TEST_DIR)/exittime.elf pv-tests += $(TEST_DIR)/pv-diags.elf
s390x/exittime.c new file +296 -0
296 lines not on this page · raw message
s390x/unittests.cfg +4 -0
@@ -201,3 +201,7 @@ timeout = 5 [migration-sck] file = migration-sck.elf groups = migration + +[exittime] +file = exittime.elf +smp = 2
Signature · 1 line
2.36.1
Re: [kvm-unit-tests PATCH v7 1/1] s390x: add exittime tests
Quoted 8 lines · On Mon, 17 Oct 2022 12:18:28 +0200 Nico Boehr <[email protected]> wrote:
Add a test to measure the execution time of several instructions. This can be helpful in finding performance regressions in hypervisor code.
All tests are currently reported as PASS, since the baseline for their execution time depends on the respective environment and since needs to be determined on a case-by-case basis.
Signed-off-by Nico Boehr <[email protected]>
Quoted 333 lines
--- s390x/Makefile | 1 + s390x/exittime.c | 296 ++++++++++++++++++++++++++++++++++++++++++++ s390x/unittests.cfg | 4 + 3 files changed, 301 insertions(+) create mode 100644 s390x/exittime.cs390x/Makefile +1
-0@@ -37,6 +37,7 @@ tests += $(TEST_DIR)/migration-skey.elf tests += $(TEST_DIR)/panic-loop-extint.elf tests += $(TEST_DIR)/panic-loop-pgm.elf tests += $(TEST_DIR)/migration-sck.elf +tests += $(TEST_DIR)/exittime.elf pv-tests += $(TEST_DIR)/pv-diags.elfs390x/exittime.c new file +296
-0@@ -0,0 +1,296 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Measure run time of various instructions. Can be used to find runtime +* regressions of instructions which cause exits. +* +* Copyright IBM Corp. 2022 +* +* Authors: +* Nico Boehr <[email protected]> +*/ +#include <libcflat.h> +#include <smp.h> +#include <sclp.h> +#include <hardware.h> +#include <asm/time.h> +#include <asm/sigp.h> +#include <asm/interrupt.h> +#include <asm/page.h> + +const uint64_t iters_to_normalize_to =10000 ; +char pagebuf[PAGE_SIZE] __attribute__((__aligned__(PAGE_SIZE))); + +static void test_sigp_sense_running (long destcpu) +{ +smp_sigp (destcpu,SIGP_SENSE_RUNNING ,0 ,NULL ); +} + +static void test_nop (long ignore) +{ +/* nops don't trap into the hypervisor, so let's test them for reference */ + asmvolatile ( +"nop" + : + : + :"memory" + ); +} + +static void test_diag9c (long destcpu) +{ + asmvolatile ( +"diag %[destcpu],0,0x9c" + : + : [destcpu]"d" (destcpu) + ); +} + +static long setup_get_this_cpuaddr (long ignore) +{ +return stap (); +} + +static void test_diag44 (long ignore) +{ + asmvolatile ( +"diag 0,0,0x44" + ); +} + +static void test_stnsm (long ignore) +{ +int out; + + asmvolatile ( +"stnsm %[out],0xff" + : [out]"=Q" (out) + ); +} + +static void test_stosm (long ignore) +{ +int out; + + asmvolatile ( +"stosm %[out],0" + : [out]"=Q" (out) + ); +} + +static long setup_ssm (long ignore) +{ +long system_mask =0 ; + + asmvolatile ( +"stosm %[system_mask],0" + : [system_mask]"=Q" (system_mask) + ); + +return system_mask; +} + +static void test_ssm (long old_system_mask) +{ + asmvolatile ( +"ssm %[old_system_mask]" + : + : [old_system_mask]"Q" (old_system_mask) + ); +} + +static long setup_lctl4 (long ignore) +{ +long ctl4_orig =0 ; + + asmvolatile ( +"stctg 4,4,%[ctl4_orig]" + : [ctl4_orig]"=S" (ctl4_orig) + ); + +return ctl4_orig; +} + +static void test_lctl4 (long ctl4_orig) +{ + asmvolatile ( +"lctlg 4,4,%[ctl4_orig]" + : + : [ctl4_orig]"S" (ctl4_orig) + ); +} + +static void test_stpx (long ignore) +{ +unsigned int prefix; + + asmvolatile ( +"stpx %[prefix]" + : [prefix]"=Q" (prefix) + ); +} + +static void test_stfl (long ignore) +{ + asmvolatile ( +"stfl 0" + : + : + :"memory" + ); +} + +static void test_epsw (long ignore) +{ +long r1, r2; + + asmvolatile ( +"epsw %[r1], %[r2]" + : [r1]"=d" (r1), [r2]"=d" (r2) + ); +} + +static void test_illegal (long ignore) +{ +expect_pgm_int (); + asmvolatile ( +".word 0" + ); +clear_pgm_int (); +} + +static long setup_servc (long arg) +{ +memset (pagebuf,0 ,PAGE_SIZE ); +return arg; +} + +static void test_servc (long ignore) +{ +SCCB *sccb = (SCCB *) pagebuf; + + sccb->h.length =8 ; +servc (0 , (unsigned long ) sccb); +} + +static void test_stsi (long fc) +{ +stsi (pagebuf, fc,2 ,2 ); +} + +struct test { +const char *name; +bool supports_tcg; +/* +* When non-null, will be called once before running the test loop. +* Its return value will be given as argument to testfunc. +*/ +long (*setupfunc)(long arg); +void (*testfunc)(long arg); +long arg; +long iters; +}const exittime_tests[] = { + {"nop" , true,NULL , test_nop,0 ,200000 }, + {"sigp sense running(0)" , true,NULL , test_sigp_sense_running,0 ,20000 }, + {"sigp sense running(1)" , true,NULL , test_sigp_sense_running,1 ,20000 }, + {"diag9c(self)" , false, setup_get_this_cpuaddr, test_diag9c,0 ,2000 }, + {"diag9c(0)" , false,NULL , test_diag9c,0 ,2000 }, + {"diag9c(1)" , false,NULL , test_diag9c,1 ,2000 }, + {"diag44" , true,NULL , test_diag44,0 ,2000 }, + {"stnsm" , true,NULL , test_stnsm,0 ,200000 }, + {"stosm" , true,NULL , test_stosm,0 ,200000 }, + {"ssm" , true, setup_ssm, test_ssm,0 ,200000 }, + {"lctl4" , true, setup_lctl4, test_lctl4,0 ,20000 }, + {"stpx" , true,NULL , test_stpx,0 ,2000 }, + {"stfl" , true,NULL , test_stfl,0 ,2000 }, + {"epsw" , true,NULL , test_epsw,0 ,20000 }, + {"illegal" , true,NULL , test_illegal,0 ,2000 }, + {"servc" , true, setup_servc, test_servc,0 ,2000 }, + {"stsi122" , true,NULL , test_stsi,1 ,200 }, + {"stsi222" , true,NULL , test_stsi,2 ,200 }, + {"stsi322" , true,NULL , test_stsi,3 ,200 }, +}; + +struct test_result { +uint64_t total; +uint64_t best; +uint64_t average; +uint64_t worst; +}; + +static uint64_t tod_to_us (uint64_t tod) +{ +return tod >>STCK_SHIFT_US ; +} + +static uint64_t tod_to_ns (uint64_t tod) +{ +return tod_to_us (tod *1000 ); +} + +static uint64_t normalize_iters (uint64_t value_to_normalize,uint64_t iters) +{ +return value_to_normalize * iters_to_normalize_to / iters; +} + +static void report_iteration_result (struct test const * test,struct test_result const * test_result) +{ +uint64_t total =tod_to_ns (normalize_iters (test_result->total, test->iters)), + best =tod_to_ns (normalize_iters (test_result->best, test->iters)), + average =tod_to_ns (normalize_iters (test_result->average, test->iters)), + worst =tod_to_ns (normalize_iters (test_result->worst, test->iters)); + +report_pass ( +"total/best/avg/worst %lu.%03lu/%lu.%03lu/%lu.%03lu/%lu.%03lu us" , + total /1000 , total %1000 , + best /1000 , best %1000 , + average /1000 , average %1000 , + worst /1000 , worst %1000 + ); +} + +int main (void ) +{ +int i, j, k, testfunc_arg; +const int outer_iters =100 ; +struct test const *current_test; +struct test_result result; +uint64_t start, end, elapsed; + +report_prefix_push ("exittime" ); +report_info ("reporting total/best/avg/worst normalized to %lu iterations" , iters_to_normalize_to); + +for (i =0 ; i <ARRAY_SIZE (exittime_tests); i++) { + current_test = &exittime_tests[i]; + result.total =0 ; + result.worst =0 ; + result.best =-1 ; +report_prefix_pushf ("%s" , current_test->name); + +if (host_is_tcg () && !current_test->supports_tcg) { +report_skip ("not supported under TCG" ); +report_prefix_pop (); +continue ; + } + + testfunc_arg = current_test->arg; +if (current_test->setupfunc) + testfunc_arg = current_test->setupfunc (testfunc_arg); + +for (j =0 ; j < outer_iters; j++) { +stckf (&start); +for (k =0 ; k < current_test->iters; k++) + current_test->testfunc (testfunc_arg); +stckf (&end); + elapsed = end - start; + result.best =MIN (result.best, elapsed); + result.worst =MAX (result.worst, elapsed); + result.total += elapsed; + } + result.average = result.total / outer_iters; +report_iteration_result (current_test, &result); +report_prefix_pop (); + } + +report_prefix_pop (); +return report_summary (); +}s390x/unittests.cfg +4
-0@@ -201,3 +201,7 @@ timeout = 5 [migration-sck] file = migration-sck.elf groups = migration + +[exittime] +file = exittime.elf +smp = 2
On Mon, 17 Oct 2022 12:18:27 +0200
Nico Boehr <[email protected]> wrote:
thanks, picked
Quoted 63 lines
v6->v7:
---
* change info message to indicate normalization and number of iterations normalized to (thanks Claudio)
v5->v6:
---
* multiply first, then divide when normalizing (thanks Claudio)
* print fractions of us (thanks Claudio)
* remove non-normalized output (thanks Claudio)
* fence dag9c since not supported under TCG
v4->v5:
---
* print normalized runtime to be able to compare runtime of instructions in a single run (thanks Claudio)
v3->v4:
---
* remove merge conflict markers (thanks Christian)
v2->v3:
---
* print average (thanks Claudio)
* have asm constraints look the same everywhere (thanks Claudio)
* rebase patchset on top of my migration sck patches[1] to make use of thetime.himprovements
v1->v2:
---
* add missing cc clobber, fix constraints forget_clock_us()(thanks Thomas)
* avoid array and use pointer to const char* (thanks Thomas)
* add comment why testing nop makes sense (thanks Thomas)
* rework constraints and clobbers (thanks Thomas)Sometimes, it is useful to measure the exit time of certain instructions to e.g. identify performance regressions in instructions emulated by the hypervisor.
This series adds a test which executes some instructions and measures their execution time. Since their execution time depends a lot on the environment at hand, all tests are reported as PASS currently.
The point of this series is not so much the instructions which have been chosen here (but your ideas are welcome), but rather the general question whether it makes sense to have a test like this in kvm-unit-tests.
This series is based on my migration sck patches[1] to make use of the
time.himprovements there.[1] https://lore.kernel.org/all/[email protected]/
Nico Boehr (1):
s390x: add exittime testss390x/Makefile | 1 + s390x/exittime.c | 296 ++++++++++++++++++++++++++++++++++++++++++++ s390x/unittests.cfg | 4 + 3 files changed, 301 insertions(+) create mode 100644 s390x/exittime.c