llist: Avoid extra memory read in llist_add_batch
PATCH 1/1 llist: Avoid extra memory read in llist_add_batch
try_cmpxchg implicitly assigns old head->first value to "first" when cmpxchg fails. There is no need to re-read the value in the loop.
Cc Andrew Morton <[email protected]>
Signed-off-by Uros Bizjak <[email protected]>
--- lib/llist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/llist.c +2 -2
@@ -26,10 +26,10 @@bool llist_add_batch (struct llist_node *new_first,struct llist_node *new_last,struct llist_head *head) { -struct llist_node *first; +struct llist_node *first =READ_ONCE (head->first);do { - new_last->next = first =READ_ONCE (head->first); + new_last->next = first; }while (!try_cmpxchg (&head->first, &first, new_first));return !first;
Signature · 1 line
2.37.3