Skip to contentSkip to conversation

llist: Avoid extra memory read in llist_add_batch

PATCH Applied Uros Bizjak 1 participant 1 message Oct 17, 2022 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 llist: Avoid extra memory read in llist_add_batch

try_cmpxchg implicitly assigns old head->first value to "first" when cmpxchg fails. There is no need to re-read the value in the loop.

---
 lib/llist.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/llist.c +2 -2
index 7d78b736e8af..6e668fa5a2c6 100644
@@ -26,10 +26,10 @@
 bool llist_add_batch(struct llist_node *new_first, struct llist_node *new_last,
 		     struct llist_head *head)
 {
-	struct llist_node *first;
+	struct llist_node *first = READ_ONCE(head->first);
 
 	do {
-		new_last->next = first = READ_ONCE(head->first);
+		new_last->next = first;
 	} while (!try_cmpxchg(&head->first, &first, new_first));
 
 	return !first;
Signature · 1 line
2.37.3