net: remove useless parameter of __sock_cmsg_send The
Subsystems (4)
PATCH 1/1 net: remove useless parameter of __sock_cmsg_send The
From: xu xin <[email protected]>
parameter 'msg' has never been used by __sock_cmsg_send, so we can remove it safely.
Reported-by Zeal Robot <[email protected]>
Signed-off-by xu xin <[email protected]>
Reviewed-by Zhang Yunkai <[email protected]>
--- include/net/sock.h | 2 +- net/core/sock.c | 4 ++-- net/ipv4/ip_sockglue.c | 2 +- net/ipv6/datagram.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)
include/net/sock.h +1 -1
@@ -1901,7 +1901,7 @@ static inline void sockcm_init(struct sockcm_cookie *sockc, *sockc = (struct sockcm_cookie ) { .tsflags = sk->sk_tsflags }; } -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc);int sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct sockcm_cookie *sockc);
net/core/sock.c +2 -2
@@ -2730,7 +2730,7 @@ struct sk_buff *sock_alloc_send_pskb(struct sock *sk, unsigned long header_len, }EXPORT_SYMBOL (sock_alloc_send_pskb); -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc) {u32 tsflags;
@@ -2784,7 +2784,7 @@ int sock_cmsg_send(struct sock *sk, struct msghdr *msg,return -EINVAL ;if (cmsg->cmsg_level !=SOL_SOCKET )continue ; - ret =__sock_cmsg_send (sk, msg, cmsg, sockc); + ret =__sock_cmsg_send (sk, cmsg, sockc);if (ret)return ret; }
net/ipv4/ip_sockglue.c +1 -1
@@ -267,7 +267,7 @@ int ip_cmsg_send(struct sock *sk, struct msghdr *msg, struct ipcm_cookie *ipc, }#endif if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc->sockc);if (err)return err;continue ;
net/ipv6/datagram.c +1 -1
@@ -771,7 +771,7 @@ int ip6_datagram_send_ctl(struct net *net, struct sock *sk, }if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc6->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc6->sockc);if (err)return err;continue ;
Signature · 1 line
2.25.1
PATCH 1/1 net: remove useless parameter of __sock_cmsg_send The
From: [email protected] Date: Wed, 19 Oct 2022 09:30:14 +0000
Quoted 8 lines
From: xu xin <[email protected]>
parameter 'msg' has never been used by
__sock_cmsg_send, so we can remove it safely.Reported-by Zeal Robot <[email protected]>Signed-off-by xu xin <[email protected]>Reviewed-by Zhang Yunkai <[email protected]>
The tail 'The' in the subject should be the head of the body. Otherwise, looks good.
Quoted 70 lines
--- include/net/sock.h | 2 +- net/core/sock.c | 4 ++-- net/ipv4/ip_sockglue.c | 2 +- net/ipv6/datagram.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)include/net/sock.h +1
-1@@ -1901,7 +1901,7 @@ static inline void sockcm_init(struct sockcm_cookie *sockc, *sockc = (struct sockcm_cookie ) { .tsflags = sk->sk_tsflags }; } -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc);int sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct sockcm_cookie *sockc);net/core/sock.c +2
-2@@ -2730,7 +2730,7 @@ struct sk_buff *sock_alloc_send_pskb(struct sock *sk, unsigned long header_len, }EXPORT_SYMBOL (sock_alloc_send_pskb); -int __sock_cmsg_send (struct sock *sk,struct msghdr *msg,struct cmsghdr *cmsg, +int __sock_cmsg_send (struct sock *sk,struct cmsghdr *cmsg,struct sockcm_cookie *sockc) {u32 tsflags;@@ -2784,7 +2784,7 @@ int sock_cmsg_send(struct sock *sk, struct msghdr *msg,return -EINVAL ;if (cmsg->cmsg_level !=SOL_SOCKET )continue ; - ret =__sock_cmsg_send (sk, msg, cmsg, sockc); + ret =__sock_cmsg_send (sk, cmsg, sockc);if (ret)return ret; }net/ipv4/ip_sockglue.c +1
-1@@ -267,7 +267,7 @@ int ip_cmsg_send(struct sock *sk, struct msghdr *msg, struct ipcm_cookie *ipc, }#endif if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc->sockc);if (err)return err;continue ;net/ipv6/datagram.c +1
-1@@ -771,7 +771,7 @@ int ip6_datagram_send_ctl(struct net *net, struct sock *sk, }if (cmsg->cmsg_level ==SOL_SOCKET ) { - err =__sock_cmsg_send (sk, msg, cmsg, &ipc6->sockc); + err =__sock_cmsg_send (sk, cmsg, &ipc6->sockc);if (err)return err;continue ;Signature · 1 line
2.25.1