Skip to contentSkip to conversation

arm64: dts: mt8195: Add Ethernet controller

PATCH Superseded Biao Huang 2 participants 4 messages Oct 20, 2022

Subsystems (2)

v3 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Biao Huang

author
#0 lore raw

v3 cover arm64: dts: mt8195: Add Ethernet controller

Changes in v3:
1. move stmmac-axi-config, rx-queues-config, tx-queues-configs inside ethernet node as Angelo's comments.
2. add {address,size}-cells = <0> in ethernet node as Angelo's comments.

Changes in v2:
1. modify pinctrl node used by ethernet to match rules in pinctrl-mt8195.yaml, which is pointed by Krzysztof.
2. remove "mac-address" property in ethernet node as comments of Krzysztof.

Changes in v1:
add dts node for MT8195 Ethernet controller

Biao Huang (1):
arm64: dts: mt8195: Add Ethernet controller

 arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
 arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88 ++++++++++++++++++++
 2 files changed, 176 insertions(+)
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v3 1/1 arm64: dts: mt8195: Add Ethernet controller

Add Ethernet controller node for mt8195.

---
 arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
 arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88 ++++++++++++++++++++
 2 files changed, 176 insertions(+)
arch/arm64/boot/dts/mediatek/mt8195-demo.dts +88 -0
index 4fbd99eb496a..0e8496d837ef 100644
@@ -258,6 +258,72 @@ &mt6359_vsram_others_ldo_reg {
 };
 
 &pio {
+	eth_default_pins: eth-default-pins {
+		pins-txd {
+			pinmux = <PINMUX_GPIO77__FUNC_GBE_TXD3>,
+				 <PINMUX_GPIO78__FUNC_GBE_TXD2>,
+				 <PINMUX_GPIO79__FUNC_GBE_TXD1>,
+				 <PINMUX_GPIO80__FUNC_GBE_TXD0>;
+			drive-strength = <MTK_DRIVE_8mA>;
+		};
+		pins-cc {
+			pinmux = <PINMUX_GPIO85__FUNC_GBE_TXC>,
+				 <PINMUX_GPIO88__FUNC_GBE_TXEN>,
+				 <PINMUX_GPIO87__FUNC_GBE_RXDV>,
+				 <PINMUX_GPIO86__FUNC_GBE_RXC>;
+			drive-strength = <MTK_DRIVE_8mA>;
+		};
+		pins-rxd {
+			pinmux = <PINMUX_GPIO81__FUNC_GBE_RXD3>,
+				 <PINMUX_GPIO82__FUNC_GBE_RXD2>,
+				 <PINMUX_GPIO83__FUNC_GBE_RXD1>,
+				 <PINMUX_GPIO84__FUNC_GBE_RXD0>;
+		};
+		pins-mdio {
+			pinmux = <PINMUX_GPIO89__FUNC_GBE_MDC>,
+				 <PINMUX_GPIO90__FUNC_GBE_MDIO>;
+			input-enable;
+		};
+		pins-power {
+			pinmux = <PINMUX_GPIO91__FUNC_GPIO91>,
+				 <PINMUX_GPIO92__FUNC_GPIO92>;
+			output-high;
+		};
+	};
+
+	eth_sleep_pins: eth-sleep-pins {
+		pins-txd {
+			pinmux = <PINMUX_GPIO77__FUNC_GPIO77>,
+				 <PINMUX_GPIO78__FUNC_GPIO78>,
+				 <PINMUX_GPIO79__FUNC_GPIO79>,
+				 <PINMUX_GPIO80__FUNC_GPIO80>;
+		};
+		pins-cc {
+			pinmux = <PINMUX_GPIO85__FUNC_GPIO85>,
+				 <PINMUX_GPIO88__FUNC_GPIO88>,
+				 <PINMUX_GPIO87__FUNC_GPIO87>,
+				 <PINMUX_GPIO86__FUNC_GPIO86>;
+		};
+		pins-rxd {
+			pinmux = <PINMUX_GPIO81__FUNC_GPIO81>,
+				 <PINMUX_GPIO82__FUNC_GPIO82>,
+				 <PINMUX_GPIO83__FUNC_GPIO83>,
+				 <PINMUX_GPIO84__FUNC_GPIO84>;
+		};
+		pins-mdio {
+			pinmux = <PINMUX_GPIO89__FUNC_GPIO89>,
+				 <PINMUX_GPIO90__FUNC_GPIO90>;
+			input-disable;
+			bias-disable;
+		};
+		pins-power {
+			pinmux = <PINMUX_GPIO91__FUNC_GPIO91>,
+				 <PINMUX_GPIO92__FUNC_GPIO92>;
+			input-disable;
+			bias-disable;
+		};
+	};
+
 	gpio_keys_pins: gpio-keys-pins {
 		pins {
 			pinmux = <PINMUX_GPIO106__FUNC_GPIO106>;
@@ -434,6 +500,28 @@ &xhci0 {
 	status = "okay";
 };
 
+&eth {
+	phy-mode ="rgmii-rxid";
+	phy-handle = <&ethernet_phy0>;
+	snps,reset-gpio = <&pio 93 GPIO_ACTIVE_HIGH>;
+	snps,reset-delays-us = <0 10000 10000>;
+	mediatek,tx-delay-ps = <2030>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&eth_default_pins>;
+	pinctrl-1 = <&eth_sleep_pins>;
+	status = "okay";
+
+	mdio {
+		compatible = "snps,dwmac-mdio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		ethernet_phy0: ethernet-phy@1 {
+			compatible = "ethernet-phy-id001c.c916";
+			reg = <0x1>;
+		};
+	};
+};
+
 &xhci1 {
 	vusb33-supply = <&mt6359_vusb_ldo_reg>;
 	status = "okay";
arch/arm64/boot/dts/mediatek/mt8195.dtsi +88 -0

94 lines not on this page · raw message

Signature · 1 line
2.25.1
maintainer Reviewed-by on v3 1/1
#2 lore raw

Il 20/10/22 04:41, Biao Huang ha scritto:

Quoted 8 lines

Add Ethernet controller node for mt8195.

---
  arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
  arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88 ++++++++++++++++++++
  2 files changed, 176 insertions(+)

..snip..

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8195.dtsi +2 -0
index 905d1a90b406..7efaf92c5ff3 100644
@@ -1042,6 +1042,94 @@ spis1: spi@1101e000 {
  			status = "disabled";
  		};
 
+		eth: ethernet@11021000 {
+			compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a";

..snip..

arch/arm64/boot/dts/mediatek/mt8195.dtsi spis1: spi@1101e000 { · line 1077

Quoted 2 lines
arch/arm64/boot/dts/mediatek/mt8195.dtsi +2 -0
+			#address-cells = <0>;
+			#size-cells = <0>;

I'm truly sorry for a partial bad suggestion, you don't need to specify address nor size cells = <0>; in the ethernet node, or you get a warning:

arch/arm64/boot/dts/mediatek/mt8195.dtsi:1174.26-1260.5: Warning (avoid_unnecessary_addr_size): /soc/ethernet@11021000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

So please remove these two.

After which...

author
#3 lore raw

Dear Angelo,
Thanks for your comments~

Quoted 36 lines · AngeloGioacchino Del Regno

Il 20/10/22 04:41, Biao Huang ha scritto:

Quoted 10 lines

Add Ethernet controller node for mt8195.

---
  arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88
++++++++++++++++++++
  arch/arm64/boot/dts/mediatek/mt8195.dtsi     | 88
++++++++++++++++++++
  2 files changed, 176 insertions(+)

..snip..

Quoted 12 lines
arch/arm64/boot/dts/mediatek/mt8195.dtsi +2 -0
index 905d1a90b406..7efaf92c5ff3 100644
@@ -1042,6 +1042,94 @@ spis1: spi@1101e000 {
  			status = "disabled";
  		};
 
+		eth: ethernet@11021000 {
+			compatible = "mediatek,mt8195-gmac",
 "snps,dwmac-5.10a";

..snip..

arch/arm64/boot/dts/mediatek/mt8195.dtsi spis1: spi@1101e000 { · line 1077

Quoted 2 lines
arch/arm64/boot/dts/mediatek/mt8195.dtsi +2 -0
+			#address-cells = <0>;
+			#size-cells = <0>;

I'm truly sorry for a partial bad suggestion, you don't need to specify address nor
size cells = <0>; in the ethernet node, or you get a warning:

Quoted 5 lines

arch/arm64/boot/dts/mediatek/mt8195.dtsi:1174.26-1260.5: Warning (avoid_unnecessary_addr_size): /soc/ethernet@11021000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

So please remove these two.

OK, will remove in next send.

Quoted 5 lines

After which...

Reviewed-by: AngeloGioacchino Del Regno <
[email protected]>

OK, will add in next send.

Quoted 2 lines

Best Regards!
Biao