Skip to contentSkip to conversation

board: tbs2910: Set all board dts files as maintained

PATCH In review Soeren Moch 3 participants 7 messages Sep 20, 2022 – Oct 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 board: tbs2910: Set all board dts files as maintained

This also includes the imx6q-tbs2910-u-boot.dtsi file now.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: "NXP i.MX U-Boot Team" <[email protected]>
Cc: [email protected]

---
 board/tbs/tbs2910/MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/tbs/tbs2910/MAINTAINERS +1 -1
index 1e3c0d0ece..72f98d1a69 100644
@@ -1,7 +1,7 @@
 TBS2910 BOARD
 M:	Soeren Moch <[email protected]>
 S:	Maintained
-F:	arch/arm/dts/imx6q-tbs2910.dts
+F:	arch/arm/dts/imx6q-tbs2910*
 F:	board/tbs/tbs2910/
 F:	configs/tbs2910_defconfig
 F:	doc/board/tbs/

--
2.34.1

#1 lore raw

PATCH 2/2 board: tbs2910: Add serial rx buffer in defconfig

... to avoid loosing characters when pasting text into the serial console. This allows to remove the workaround to disable the vidconsole output when no HDMI device is detected. This workaround only was there to speed-up serial console processing.

---
Cc: Stefano Babic <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: "NXP i.MX U-Boot Team" <[email protected]>
Cc: [email protected]

---
 configs/tbs2910_defconfig | 3 ++-
 include/configs/tbs2910.h | 4 ----
 2 files changed, 2 insertions(+), 5 deletions(-)
configs/tbs2910_defconfig +2 -1
index 59444372e9..20de590e27 100644
@@ -24,7 +24,7 @@ CONFIG_BOOTDELAY=3
 CONFIG_USE_BOOTCOMMAND=y
 CONFIG_BOOTCOMMAND="mmc rescan; if run bootcmd_up1; then run bootcmd_up2; else run bootcmd_mmc || run distro_bootcmd; fi"
 CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="echo PCI:; pci enum; pci 1; usb start; if hdmidet; then run set_con_hdmi; else run set_con_serial; fi"
+CONFIG_PREBOOT="echo PCI:; pci enum; pci 1; usb start"
 CONFIG_DEFAULT_FDT_FILE="imx6q-tbs2910.dtb"
 CONFIG_PRE_CONSOLE_BUFFER=y
 CONFIG_HUSH_PARSER=y
@@ -89,6 +89,7 @@ CONFIG_PINCTRL_IMX6=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_DS1307=y
 CONFIG_DM_SERIAL=y
+CONFIG_SERIAL_RX_BUFFER=y
 CONFIG_MXC_UART=y
 CONFIG_DM_THERMAL=y
 CONFIG_IMX_THERMAL=y
include/configs/tbs2910.h +0 -4
index c93df00d58..7f197851d0 100644
@@ -61,10 +61,6 @@
 	"pxefile_addr_r=0x10100000\0" \
 	"ramdisk_addr_r=0x18080000\0" \
 	"scriptaddr=0x10000000\0" \
-	"set_con_serial=setenv stdout serial; " \
-			"setenv stderr serial\0" \
-	"set_con_hdmi=setenv stdout serial,vidconsole; " \
-			"setenv stderr serial,vidconsole\0" \
 	"stderr=serial,vidconsole\0" \
 	"stdin=serial,usbkbd\0" \
 	"stdout=serial,vidconsole\0"

--
2.34.1

Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] board: tbs2910: Add serial rx buffer in defconfig

Quoted 7 lines · Soeren Moch

... to avoid loosing characters when pasting text into the serial console. This allows to remove the workaround to disable the vidconsole output when no HDMI device is detected. This workaround only was there to speed-up serial console processing.

#3 lore raw

Re: [PATCH 2/2] board: tbs2910: Add serial rx buffer in defconfig

Quoted 8 lines · Fabio Estevam
Quoted 6 lines · Soeren Moch

... to avoid loosing characters when pasting text into the serial console. This allows to remove the workaround to disable the vidconsole output when no HDMI device is detected. This workaround only was there to speed-up serial console processing.

Thanks, Fabio!

I forgot to mention: This is not urgent. It is totally fine to queue this series for -next.

Thanks,
Soeren

#4 lore raw

PATCH 2/2 board: tbs2910: Add serial rx buffer in defconfig

In reply to Soeren Moch
Quoted 6 lines

... to avoid loosing characters when pasting text into the serial console. This allows to remove the workaround to disable the vidconsole output when no HDMI device is detected. This workaround only was there to speed-up serial console processing.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
#6 lore raw

PATCH 1/2 board: tbs2910: Set all board dts files as maintained

In reply to Soeren Moch
Quoted 3 lines

This also includes the imx6q-tbs2910-u-boot.dtsi file now.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================