arm64: dts: add new compatibles for J7 platforms
Subsystems (3)
v2 cover arm64: dts: add new compatibles for J7 platforms
Changes from v1:
* add j7200 and j721s2 syscon compatible strings to dt-binding documentation
* changed compatible strings to use newly defined ones per platform
Matt Ranostay (2):
dt-bindings: mfd: ti,j721e-system-controller: add compatible strings
for other platforms
arm64: dts: k3-j72*: correct compatible for syscon entries
.../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 ++ arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
2.38.GIT
PATCH RESEND v2 1/2 dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms
There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.
This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.
--- .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +2 -0
@@ -26,7 +26,9 @@ properties: compatible: items: - enum: + - ti,j7200-system-controller - ti,j721e-system-controller + - ti,j721s2-system-controller - const: syscon - const: simple-mfd
Signature · 1 line
2.38.GIT
Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms
Quoted 11 lines · Matt Ranostay
There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.
This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.
Signed-off-by Matt Ranostay <[email protected]>--- .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 ++ 1 file changed, 2 insertions(+)
Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms
In reply to Matt RanostayQuoted 6 lines · Matt Ranostay
There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.
This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Best regards,
Krzysztof
Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms
In reply to Matt RanostayQuoted 10 lines · Matt Ranostay
There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.
This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.
Signed-off-by Matt Ranostay <[email protected]>--- .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 ++ 1 file changed, 2 insertions(+)
Applied, thanks.
Signature · 1 line
Lee Jones [李琼斯]
PATCH RESEND v2 2/2 arm64: dts: k3-j72*: correct compatible for syscon entries
In reply to Matt RanostayAdd missing ti,j7*-system-controller compatible to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'
--- arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 2 +- arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j7200-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
@@ -35,7 +35,7 @@ k3_reset: reset-controller { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1 -1
@@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 { }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721s2-system-controller", "syscon", "simple-mfd"; reg = <0x0 0x40f00000 0x0 0x20000>; #address-cells = <1>; #size-cells = <1>;
Signature · 1 line
2.38.GIT
Re: [PATCH RESEND v2 2/2] arm64: dts: k3-j72*: correct compatible for syscon entries
Quoted 5 lines · Matt Ranostay
Add missing ti,j7*-system-controller compatible to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'
This is a friendly reminder during the review process.
It looks like you received a tag and forgot to add it.
If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
Best regards,
Krzysztof