Skip to contentSkip to conversation

arm64: dts: add new compatibles for J7 platforms

PATCH RESEND Applied Matt Ranostay 4 participants 7 messages Oct 24, 2022 – Oct 31, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v2 cover arm64: dts: add new compatibles for J7 platforms

Changes from v1:
* add j7200 and j721s2 syscon compatible strings to dt-binding documentation
* changed compatible strings to use newly defined ones per platform

Matt Ranostay (2):
dt-bindings: mfd: ti,j721e-system-controller: add compatible strings
for other platforms
arm64: dts: k3-j72*: correct compatible for syscon entries

 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi                 | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi                 | 2 +-
 arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi                | 2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
2.38.GIT
#1 lore raw

PATCH RESEND v2 1/2 dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms

There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.

This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +2 -0
index 873ee0c0973f..76ef4352e13c 100644
@@ -26,7 +26,9 @@ properties:
   compatible:
     items:
       - enum:
+          - ti,j7200-system-controller
           - ti,j721e-system-controller
+          - ti,j721s2-system-controller
       - const: syscon
       - const: simple-mfd
 
Signature · 1 line
2.38.GIT
maintainer Acked-by on v2 1/2
#2 lore raw

Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms

Quoted 11 lines · Matt Ranostay

There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.

This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
 1 file changed, 2 insertions(+)
#3 lore raw

Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms

In reply to Matt Ranostay
Quoted 6 lines · Matt Ranostay

There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.

This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

maintainer Applied
#4 lore raw

Re: [PATCH RESEND v2 1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms

In reply to Matt Ranostay
Quoted 10 lines · Matt Ranostay

There are multiple J7 based platforms, and the j721e-system-controller shouldn't be define in non-j721e devices device trees.

This is mainly for clarity; but also useful in case there are future erratas that need to be fixed for a specific platform.

---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks.

Signature · 1 line
Lee Jones [李琼斯]
#5 lore raw

PATCH RESEND v2 2/2 arm64: dts: k3-j72*: correct compatible for syscon entries

In reply to Matt Ranostay

Add missing ti,j7*-system-controller compatible to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'

---
 arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi  | 2 +-
 arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi  | 2 +-
 arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +1 -1
index e5be78a58682..2025aab4b66f 100644
@@ -35,7 +35,7 @@ k3_reset: reset-controller {
 	};
 
 	mcu_conf: syscon@40f00000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,j7200-system-controller", "syscon", "simple-mfd";
 		reg = <0x00 0x40f00000 0x00 0x20000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi +1 -1
index df08724bbf1c..5d9ec221fa34 100644
@@ -35,7 +35,7 @@ k3_reset: reset-controller {
 	};
 
 	mcu_conf: syscon@40f00000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
 		reg = <0x0 0x40f00000 0x0 0x20000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +1 -1
index 4d1bfabd1313..dfd40369b931 100644
@@ -69,7 +69,7 @@ wkup_gpio_intr: interrupt-controller@42200000 {
 	};
 
 	mcu_conf: syscon@40f00000 {
-		compatible = "syscon", "simple-mfd";
+		compatible = "ti,j721s2-system-controller", "syscon", "simple-mfd";
 		reg = <0x0 0x40f00000 0x0 0x20000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
Signature · 1 line
2.38.GIT
#6 lore raw

Re: [PATCH RESEND v2 2/2] arm64: dts: k3-j72*: correct compatible for syscon entries

Quoted 5 lines · Matt Ranostay

Add missing ti,j7*-system-controller compatible to bus defines in mcu/wakeup domains to avoid the following similar warnings from dt-schema checks:

arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: syscon@40f00000: compatible: ['syscon', 'simple-mfd'] is too short'

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof