imx: imx8qm-rom7720: switch to binman
Subsystems (3)
PATCH v3 1/1 imx: imx8qm-rom7720: switch to binman
Switch to use binman to pack images
---
Changes for v3
- just rebased to master
Changes for v2
- just rebased to master
arch/arm/dts/imx8qm-rom7720-a1.dts | 1 + arch/arm/dts/imx8qm-u-boot.dtsi | 133 ++++++++++++++++++ arch/arm/mach-imx/imx8/Kconfig | 1 + .../advantech/imx8qm_rom7720_a1/imximage.cfg | 4 +- configs/imx8qm_rom7720_a1_4G_defconfig | 2 +- doc/board/advantech/imx8qm-rom7720-a1.rst | 3 +- 6 files changed, 139 insertions(+), 5 deletions(-) create mode 100644 arch/arm/dts/imx8qm-u-boot.dtsi
arch/arm/dts/imx8qm-rom7720-a1.dts +1 -0
@@ -10,6 +10,7 @@ /memreserve/ 0x80000000 0x00020000; #include "fsl-imx8qm.dtsi" +#include "imx8qm-u-boot.dtsi" / { model = "Advantech iMX8QM Qseven series";
arch/arm/dts/imx8qm-u-boot.dtsi new file +133 -0
133 lines not on this page · raw message
arch/arm/mach-imx/imx8/Kconfig +1 -0
@@ -82,6 +82,7 @@ config TARGET_CONGA_QMX8 config TARGET_IMX8QM_ROM7720_A1 bool "Support i.MX8QM ROM-7720-A1" + select BINMAN select BOARD_LATE_INIT select SUPPORT_SPL select IMX8QM
board/advantech/imx8qm_rom7720_a1/imximage.cfg +2 -2
@@ -4,8 +4,8 @@ */ -/* Boot from SD, sector size 0x400 */ -BOOT_FROM SD 0x400 +BOOT_FROM sd + /* SoC type IMX8QM */ SOC_TYPE IMX8QM /* Append seco container image */
configs/imx8qm_rom7720_a1_4G_defconfig +1 -1
@@ -21,7 +21,7 @@ CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 CONFIG_REMAKE_ELF=y CONFIG_FIT=y CONFIG_SPL_LOAD_FIT=y -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +# CONFIG_USE_SPL_FIT_GENERATOR is not set CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTCOMMAND=y CONFIG_BOOTCOMMAND="mmc dev ${mmcdev}; if mmc rescan; then if run loadbootscript; then run bootscript; else if run loadimage; then run mmcboot; else run netboot; fi; fi; else booti ${loadaddr} - ${fdt_addr}; fi"
doc/board/advantech/imx8qm-rom7720-a1.rst +1 -2
@@ -57,8 +57,7 @@ Build U-Boot $ export ATF_LOAD_ADDR=0x80000000 $ export BL33_LOAD_ADDR=0x80020000 $ make imx8qm_rom7720_a1_4G_defconfig - $ make u-boot.bin - $ make flash.bin + $ make Flash the binary into the SD card ---------------------------------
Signature · 1 line
2.17.1
Fabio Estevam
reviewerHi Oliver,
Review
Quoted 2 lines · Oliver Graute
(quoted diff) +2
-0+ fdt { + filename = "imx8qm-rom7720-a1";
Please do not hardcode this dtb filename inside the common imx8qm-u-boot.dtsi file.
You can look at arch/arm/dts/imx8mm-u-boot.dtsi as a reference.
Quoted 5 lines
arch/arm/dts/imx8qm-u-boot.dtsi new file +5
-0+ type = "flat_dt"; + compression = "none"; + + uboot_fdt_blob { + filename = "u-boot.dtb";
arch/arm/dts/imx8qm-u-boot.dtsi line 114
Quoted 10 lines
arch/arm/dts/imx8qm-u-boot.dtsi new file +10
-0+ type = "blob-ext"; + }; + }; + }; + + configurations { + default = "conf"; + + conf { + filename = "imx8qm-rom7720-a1";
Same here.
Also, could you please try converting all imx8mq/qxp boards to binman?
Thanks
Quoted 10 lines · Fabio Estevam
Hi Oliver,
Review
Quoted 2 lines · Oliver Graute
(quoted diff) +2
-0+ fdt { + filename = "imx8qm-rom7720-a1";Please do not hardcode this dtb filename inside the common
imx8qm-u-boot.dtsifile.
OK I'll remove the line
Quoted 2 lines
You can look at
arch/arm/dts/imx8mm-u-boot.dtsias a reference.
OK
Quoted 10 lines
Quoted 10 lines
arch/arm/dts/imx8qm-u-boot.dtsi new file +9
-0+ type = "flat_dt"; + compression = "none"; + + uboot_fdt_blob { + filename = "u-boot.dtb"; + type = "blob-ext"; + }; + }; + };
Quoted 8 lines
arch/arm/dts/imx8qm-u-boot.dtsi line 114
Quoted 6 lines
arch/arm/dts/imx8qm-u-boot.dtsi new file +6
-0+ + configurations { + default = "conf"; + + conf { + filename = "imx8qm-rom7720-a1";Same here.
Ok
Quoted 2 lines
Also, could you please try converting all imx8mq/qxp boards to binman?
ok I'll try this.
Quoted 1 line
Thanks
Best regards,
Oliver