Revert "cli_readline: Only insert printable chars"
PATCH 1/1 Revert "cli_readline: Only insert printable chars"
This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.
This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by Pali Rohár <[email protected]>
--- common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
common/cli_readline.c +2 -4
@@ -517,10 +517,8 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len, }#endif default : -if (ichar >=' ' && ichar <='~' ) { -cread_add_char (ichar, insert, &num, &eol_num, - buf, *len); - } +cread_add_char (ichar, insert, &num, &eol_num, buf, + *len);break ; } }
Signature · 1 line
2.20.1
Quoted 10 lines · Pali Rohár
This reverts commit
d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by Pali Rohár <[email protected]>--- common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by Simon Glass <[email protected]>
Quoted 7 lines · On Tuesday 01 November 2022 21:07:24 Simon Glass wrote:
Quoted 6 lines · Pali Rohár
This reverts commit
d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Pali Rohár <[email protected]>--- common/cli_readline.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)Reviewed-by Simon Glass <[email protected]>
Hello! Any objection? If not, could you take this patch?
Quoted 7 lines · Pali Rohár
This reverts commit
d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.
Signed-off-by Pali Rohár <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom