Skip to contentSkip to conversation

Revert "cli_readline: Only insert printable chars"

PATCH In review Pali Rohár 3 participants 4 messages Nov 1, 2022 – Nov 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "cli_readline: Only insert printable chars"

This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.

This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.

---
 common/cli_readline.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
common/cli_readline.c +2 -4
index f6e2bcdeceb2..d6444f5fc1d3 100644
@@ -517,10 +517,8 @@ static int cread_line(const char *const prompt, char *buf, unsigned int *len,
 		}
 #endif
 		default:
-			if (ichar >= ' ' && ichar <= '~') {
-				cread_add_char(ichar, insert, &num, &eol_num,
-					       buf, *len);
-			}
+			cread_add_char(ichar, insert, &num, &eol_num, buf,
+				       *len);
 			break;
 		}
 	}
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Pali Rohár

This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.

This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.

---
 common/cli_readline.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
#2 lore raw
Quoted 7 lines · On Tuesday 01 November 2022 21:07:24 Simon Glass wrote:
Quoted 6 lines · Pali Rohár

This reverts commit d2e64d29c44dee6d455f7705dd1cf1af8674ad9a.

This commit broke support for pound sign (£) and euro sign (€) keys on Nokia N900 keypad.

Quoted 6 lines
Quoted 4 lines
---
 common/cli_readline.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Hello! Any objection? If not, could you take this patch?