imx: imx8qm: cgtqmx8: switch to binman
Subsystems (3)
PATCH v6 1/1 imx: imx8qm: cgtqmx8: switch to binman
Switch to use binman to pack images
---
Changes for v6
- added CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set
Changes for v5
- added CONFIG_FIT_EXTERNAL_OFFSET
Changes for v4
- rebased on master
Changes for v3
-added Reviewed-by
- rebased on master
arch/arm/dts/imx8qm-cgtqmx8.dts | 1 + arch/arm/mach-imx/imx8/Kconfig | 1 + board/congatec/cgtqmx8/imximage.cfg | 4 ++-- configs/cgtqmx8_defconfig | 4 +++- doc/board/congatec/cgtqmx8.rst | 3 +-- 5 files changed, 8 insertions(+), 5 deletions(-)
arch/arm/dts/imx8qm-cgtqmx8.dts +1 -0
@@ -12,6 +12,7 @@ /memreserve/ 0x80000000 0x00020000; #include "fsl-imx8qm.dtsi" +#include "imx8qm-u-boot.dtsi" / { model = "Congatec QMX8 Qseven series";
arch/arm/mach-imx/imx8/Kconfig +1 -0
@@ -76,6 +76,7 @@ config TARGET_IMX8QM_MEK config TARGET_CONGA_QMX8 bool "Support congatec conga-QMX8 board" + select BINMAN select BOARD_LATE_INIT select SUPPORT_SPL select IMX8QM
board/congatec/cgtqmx8/imximage.cfg +2 -2
@@ -4,8 +4,8 @@ */ -/* Boot from SD, sector size 0x400 */ -BOOT_FROM SD 0x400 +BOOT_FROM sd + /* SoC type IMX8QM */ SOC_TYPE IMX8QM /* Append seco container image */
configs/cgtqmx8_defconfig +3 -1
@@ -20,8 +20,10 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x80200000 CONFIG_REMAKE_ELF=y CONFIG_FIT=y +CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" +# CONFIG_USE_SPL_FIT_GENERATOR is not set +# CONFIG_SPL_BINMAN_UBOOT_SYMBOLS is not set CONFIG_OF_BOARD_SETUP=y CONFIG_BOOTDELAY=3 CONFIG_USE_BOOTCOMMAND=y
doc/board/congatec/cgtqmx8.rst +1 -2
@@ -57,8 +57,7 @@ Build U-Boot $ export ATF_LOAD_ADDR=0x80000000 $ export BL33_LOAD_ADDR=0x80020000 $ make cgtqmx8_defconfig - $ make u-boot.bin - $ make flash.bin + $ make Flash the binary into the SD card ---------------------------------
Signature · 1 line
2.17.1
Fabio Estevam
reviewerHi Oliver,
Quoted 2 lines · Oliver Graute
#include "
fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"
This file does not exist in U-Boot mainline.
I know you added it as part of another patch, but please send a patch series so that all dependencies are available.
What about the other imx8mq boards? Do you plan to convert them too?
If so, please send a series doing the full binman conversion of all imx8qm boards.
Thanks
Quoted 5 lines · Fabio Estevam
Hi Oliver,
On Wed, Nov 2, 2022 at 6:12 AM Oliver Graute
<[email protected]> wrote:
Quoted 7 lines
Quoted 2 lines
#include "
fsl-imx8qm.dtsi"
+#include "imx8qm-u-boot.dtsi"This file does not exist in U-Boot mainline.
I know you added it as part of another patch, but please send a patch series so that all dependencies are available.
Ok, I try to send them all as series next time.
Quoted 2 lines
What about the other imx8mq boards? Do you plan to convert them too?
I have these boards in mind for missing binman support:
imx8qm-rom7720, cgtqmx8, imx8qxp, imx8qm_mek, giedi, deneb, colibri_imx8x, apalis_imx8
After checking arch/arm/mach-imx/imx8/Kconfig and arch/arm/mach-imx/imx8m/Kconfig I see no more imx8mq boards which needs porting to binman.
But nxp naming is easy to confuse so perhaps I missed some boards. Can you tell me which imx8mq boards you mean exactly? then I would try port them to.
Quoted 3 lines
If so, please send a series doing the full binman conversion of all imx8qm boards.
Ok
Best Regards,
Oliver
Fabio Estevam
reviewerQuoted 5 lines · Oliver Graute
I have these boards in mind for missing binman support:
imx8qm-rom7720, cgtqmx8, imx8qxp,
imx8qm_mek, giedi, deneb,colibri_imx8x,apalis_imx8
Quoted 7 lines
After checking
arch/arm/mach-imx/imx8/Kconfigandarch/arm/mach-imx/imx8m/KconfigI see no more imx8mq boards which needs porting to binman.But nxp naming is easy to confuse so perhaps I missed some boards. Can you tell me which imx8mq boards you mean exactly? then I would try port them to.
Your list is complete:
git grep CONFIG_ARCH_IMX8=y configs/
configs/apalis-imx8_defconfig:CONFIG_ARCH_IMX8=y configs/cgtqmx8_defconfig:CONFIG_ARCH_IMX8=y configs/colibri-imx8x_defconfig:CONFIG_ARCH_IMX8=y configs/deneb_defconfig:CONFIG_ARCH_IMX8=y configs/giedi_defconfig:CONFIG_ARCH_IMX8=y configs/imx8qm_mek_defconfig:CONFIG_ARCH_IMX8=y configs/imx8qm_rom7720_a1_4G_defconfig:CONFIG_ARCH_IMX8=y configs/imx8qxp_mek_defconfig:CONFIG_ARCH_IMX8=y
Thanks for working on this.