add hotplug depedency info
v4 cover add hotplug depedency info
v3->v4: Add Mika's review tag.
v2->v3: Dependency comment made more precise and technical, as suggested by Mika Westerberg.
v1->v2: I added comments that PCIe cards with USB4 or Thunderbolt also require the hotplug feature. I also added the "default y if USB4" line to the relevant config options, as suggested by Lukas Wunner.
Albert Zhou (2):
pci: hotplug: add dependency info to Kconfig
pci: pcie: add dependency info to Kconfig
drivers/pci/hotplug/Kconfig | 4 +++- drivers/pci/pcie/Kconfig | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-)
base-commit: e01d50cbd6eece456843717a566a34e8b926cf0c
Signature · 1 line
2.34.1
PATCH v4 1/2 pci: hotplug: add dependency info to Kconfig
Thunderbolt/USB4 PCIe tunneling require the Hotplug feature. This is now recorded in the help message for HOTPLUG_PCI. Further, HOTPLUG_PCI is defaulted to Y if USB4 is selected.
--- drivers/pci/hotplug/Kconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/hotplug/Kconfig +3 -1
@@ -6,10 +6,12 @@ menuconfig HOTPLUG_PCI bool "Support for PCI Hotplug" depends on PCI && SYSFS + default y if USB4 help Say Y here if you have a motherboard with a PCI Hotplug controller. This allows you to add and remove PCI cards while the machine is - powered up and running. + powered up and running. Thunderbolt/USB4 PCIe tunneling needs Native + PCIe Hotplug to be enabled. PCIe Hotplug depends on PCI Hotplug. When in doubt, say N.
Signature · 1 line
2.34.1
PATCH v4 2/2 pci: pcie: add dependency info to Kconfig
In reply to Albert ZhouThunderbolt/USB4 PCIe tunneling require the Hotplug feature. This is now recorded in the help message for HOTPLUG_PCI_PCIE. Further, PCIEPORTBUS and HOTPLUG_PCI_PCIE are defaulted to Y if USB4 is selected.
--- drivers/pci/pcie/Kconfig | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/pci/pcie/Kconfig +4 -2
@@ -4,20 +4,22 @@ # config PCIEPORTBUS bool "PCI Express Port Bus support" + default y if USB4 help This enables PCI Express Port Bus support. Users can then enable support for Native Hot-Plug, Advanced Error Reporting, Power Management Events, and Downstream Port Containment. - # # Include service Kconfig here # config HOTPLUG_PCI_PCIE bool "PCI Express Hotplug driver" depends on HOTPLUG_PCI && PCIEPORTBUS + default y if USB4 help Say Y here if you have a motherboard that supports PCI Express Native - Hotplug + Hotplug. Thunderbolt/USB4 PCIe tunneling needs Native PCIe Hotplug to + be enabled When in doubt, say N.
Signature · 1 line
2.34.1
Quoted 9 lines · Albert Zhou
v3->v4: Add Mika's review tag.
v2->v3: Dependency comment made more precise and technical, as suggested by Mika Westerberg.
v1->v2: I added comments that PCIe cards with USB4 or Thunderbolt also require the hotplug feature. I also added the "default y if USB4" line to the relevant config options, as suggested by Lukas Wunner.
Quoted 7 lines
Albert Zhou (2):
pci: hotplug: add dependency info toKconfig
pci: pcie: add dependency info toKconfigdrivers/pci/hotplug/Kconfig | 4 +++- drivers/pci/pcie/Kconfig | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-)
No need to repost just to add Reviewed-by or other tags. b4 does that automatically.
I squashed these since it's really a single logical change.
I updated to follow the style conventions for subject lines, add info to subject line, and drop extraneous whitespace change.
Applied to pci/hotplug for v6.2, thanks!
commit e67ad9354a9b ("PCI: pciehp: Enable by default if USB4 enabled")
Author: Albert Zhou <[email protected]> Date: Tue Nov 15 22:38:56 2022 +1100
PCI: pciehp: Enable by default if USB4 enabled
Thunderbolt/USB4 PCIe tunneling depends on native PCIe hotplug. Enable pciehp by default if USB4 is enabled.
drivers/pci/hotplug/Kconfig +3 -0
@@ -6,11 +6,14 @@ menuconfig HOTPLUG_PCI bool "Support for PCI Hotplug" depends on PCI && SYSFS + default y if USB4 help Say Y here if you have a motherboard with a PCI Hotplug controller. This allows you to add and remove PCI cards while the machine is powered up and running. + Thunderbolt/USB4 PCIe tunneling depends on native PCIe hotplug. + When in doubt, say N. if HOTPLUG_PCI
drivers/pci/pcie/Kconfig +6 -2
@@ -4,6 +4,7 @@ # config PCIEPORTBUS bool "PCI Express Port Bus support" + default y if USB4 help This enables PCI Express Port Bus support. Users can then enable support for Native Hot-Plug, Advanced Error Reporting, Power
@@ -15,9 +16,12 @@ config PCIEPORTBUS config HOTPLUG_PCI_PCIE bool "PCI Express Hotplug driver" depends on HOTPLUG_PCI && PCIEPORTBUS + default y if USB4 help - Say Y here if you have a motherboard that supports PCI Express Native - Hotplug + Say Y here if you have a motherboard that supports PCIe native + hotplug. + + Thunderbolt/USB4 PCIe tunneling depends on native PCIe hotplug. When in doubt, say N.