Skip to contentSkip to conversation

ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

PATCH Applied Fabio Estevam 3 participants 3 messages Nov 21, 2022 – Dec 31, 2022

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:

make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.

Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by serial.yaml.

Fix the problem by removing the incorrect 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
---
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -1
index 4bc4371e6bae..4b81a975c979 100644
@@ -632,7 +632,6 @@ &ssi1 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-	uart-has-rtscts;
 	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 37 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:

make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.

Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by serial.yaml.

Fix the problem by removing the incorrect 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
---
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -2
index 4bc4371e6bae..4b81a975c979 100644
@@ -632,7 +632,6 @@ &ssi1 {
 &uart1 {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_uart1>;
-       uart-has-rtscts;
        rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
        status = "okay";
 };
--
Quoted 2 lines

2.25.1

Fabio,

Thanks,

Best Regards,

Tim

Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 12 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The following build warning is seen when running:

make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.

Quoted 7 lines

Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by serial.yaml.

Fix the problem by removing the incorrect 'uart-has-rtscts' property.

Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")

Applied, thanks!