ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
The imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.
Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by serial.yaml.
Fix the problem by removing the incorrect 'uart-has-rtscts' property.
--- arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0 -1
@@ -632,7 +632,6 @@ &ssi1 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; - uart-has-rtscts; rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; };
Signature · 1 line
2.25.1
Quoted 37 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
make
dtbs_checkDT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema:Documentation/devicetree/bindings/serial/fsl-imx-uart.yamlThe imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.
Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by
serial.yaml.Fix the problem by removing the incorrect 'uart-has-rtscts' property.
Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 - 1 file changed, 1 deletion(-)arch/arm/boot/dts/imx6qdl-gw560x.dtsi +0
-2@@ -632,7 +632,6 @@ &ssi1 { &uart1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_uart1>; - uart-has-rtscts; rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>; status = "okay"; }; --
Quoted 2 lines
2.25.1
Fabio,
Thanks,
Best Regards,
Tim
Shawn Guo
AppliedQuoted 12 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The following build warning is seen when running:
make
dtbs_checkDT_SCHEMA_FILES=fsl-imx-uart.yaml
arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
From schema:Documentation/devicetree/bindings/serial/fsl-imx-uart.yamlThe imx6qdl-gw560x board does not expose the UART RTS and CTS as native UART pins, so 'uart-has-rtscts' should not be used.
Quoted 7 lines
Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination detected by
serial.yaml.Fix the problem by removing the incorrect 'uart-has-rtscts' property.
Fixes b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")Signed-off-by Fabio Estevam <[email protected]>
Applied, thanks!