efi_loader: Fix buffer underflow If the array index 'i' < 128, the 'codepage' array is accessed using [-128...-1] in efi_unicode_collation.c:262. This can lead to a buffer overflow. Negative index in efi_unicode_collation.c:262. The index of the 'codepage' array should be c-0x80 instead of i-0x80.
PATCH 1/1 efi_loader: Fix buffer underflow If the array index 'i' < 128, the 'codepage' array is accessed using [-128...-1] in efi_unicode_collation.c:262. This can lead to a buffer overflow. Negative index in efi_unicode_collation.c:262. The index of the 'codepage' array should be c-0x80 instead of i-0x80.
Fixes 0bc4b0da7b59 ("efi_loader: EFI_UNICODE_COLLATION_PROTOCOL")
Signed-off-by Mikhail Ilin <[email protected]>
--- lib/efi_loader/efi_unicode_collation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/efi_loader/efi_unicode_collation.c +1 -1
@@ -259,7 +259,7 @@ static void EFIAPI efi_fat_to_str(struct efi_unicode_collation_protocol *this,for (i =0 ; i < fat_size; ++i) { c = (unsigned char )fat[i];if (c >0x80 ) - c = codepage[i -0x80 ]; + c = codepage[c -0x80 ]; string[i] = c;if (!c)break ;
Signature · 1 line
2.17.1
Quoted 1 line · Mikhail Ilin
Fixes 0bc4b0da7b59 ("efi_loader: EFI_UNICODE_COLLATION_PROTOCOL")
Thank you for reporting the problem.
The commit message should not be in the title.
Otherwise:
Reviewed-by Heinrich Schuchardt <[email protected]>
Quoted 18 lines
Signed-off-by Mikhail Ilin <[email protected]>--- lib/efi_loader/efi_unicode_collation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/efi_loader/efi_unicode_collation.c +1
-1@@ -259,7 +259,7 @@ static void EFIAPI efi_fat_to_str(struct efi_unicode_collation_protocol *this,for (i =0 ; i < fat_size; ++i) { c = (unsigned char )fat[i];if (c >0x80 ) - c = codepage[i -0x80 ]; + c = codepage[c -0x80 ]; string[i] = c;if (!c)break ;