clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
Subsystems (3)
PATCH 1/1 clk: qcom: rpmh: add support for SM6350 rpmh IPA clock
From: Luca Weiss <[email protected]>
The IPA core clock is required for SM6350. Define it.
--- drivers/clk/qcom/clk-rpmh.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/clk/qcom/clk-rpmh.c +2 -0
@@ -603,6 +603,7 @@ static const struct clk_rpmh_desc clk_rpmh_sc7280 = {DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk2, ln_bb_clk2_ao,"lnbclkg2" ,4 );DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk3, ln_bb_clk3_ao,"lnbclkg3" ,4 );DEFINE_CLK_RPMH_ARC (sm6350, qlink, qlink_ao,"qphy.lvl" ,0x1 ,4 ); +DEFINE_CLK_RPMH_BCM (sm6350, ipa,"IP0" );static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_CXO_CLK ] = &sc7280_bi_tcxo.hw,
@@ -613,6 +614,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_LN_BB_CLK3_A] = &sm6350_ln_bb_clk3_ao.hw, [RPMH_QLINK_CLK] = &sm6350_qlink.hw, [RPMH_QLINK_CLK_A] = &sm6350_qlink_ao.hw, + [RPMH_IPA_CLK] = &sm6350_ipa.hw, };static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
Signature · 1 line
2.34.1
Quoted 23 lines · Alex Elder
From: Luca Weiss <[email protected]>
The IPA core clock is required for SM6350. Define it.
Signed-off-by Luca Weiss <[email protected]>--- drivers/clk/qcom/clk-rpmh.c | 2 ++ 1 file changed, 2 insertions(+)drivers/clk/qcom/clk-rpmh.c +1
-0@@ -603,6 +603,7 @@ static const struct clk_rpmh_desc clk_rpmh_sc7280 = {DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk2, ln_bb_clk2_ao,"lnbclkg2" ,4 );DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk3, ln_bb_clk3_ao,"lnbclkg3" ,4 );DEFINE_CLK_RPMH_ARC (sm6350, qlink, qlink_ao,"qphy.lvl" ,0x1 ,4 ); +DEFINE_CLK_RPMH_BCM (sm6350, ipa,"IP0" );static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_CXO_CLK ] = &sc7280_bi_tcxo.hw,
drivers/clk/qcom/clk-rpmh.c static struct clk_hw *sm6350_rpmh_clocks[] = { · line 617
Quoted 4 lines
drivers/clk/qcom/clk-rpmh.c +1
-0@@ -613,6 +614,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_LN_BB_CLK3_A] = &sm6350_ln_bb_clk3_ao.hw, [RPMH_QLINK_CLK] = &sm6350_qlink.hw, [RPMH_QLINK_CLK_A] = &sm6350_qlink_ao.hw, + [RPMH_IPA_CLK] = &sm6350_ipa.hw,
This can use sdm845_ipa.hw instead of defining new clocks.
Quoted 6 lines
drivers/clk/qcom/clk-rpmh.c +0
-1};static const struct clk_rpmh_desc clk_rpmh_sm6350 = { --2.34.1
Signature · 2 lines
With best wishes Dmitry
Quoted 11 lines · Dmitry Baryshkov
Quoted 10 lines · Alex Elder
From: Luca Weiss <[email protected]>
The IPA core clock is required for SM6350. Define it.
Signed-off-by Luca Weiss <[email protected]>--- drivers/clk/qcom/clk-rpmh.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 9 lines
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sc7280 = { · line 606
Quoted 9 lines
drivers/clk/qcom/clk-rpmh.c +1
-0@@ -603,6 +603,7 @@ static const struct clk_rpmh_desc clk_rpmh_sc7280 = {DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk2, ln_bb_clk2_ao,"lnbclkg2" ,4 );DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk3, ln_bb_clk3_ao,"lnbclkg3" ,4 );DEFINE_CLK_RPMH_ARC (sm6350, qlink, qlink_ao,"qphy.lvl" ,0x1 ,4 ); +DEFINE_CLK_RPMH_BCM (sm6350, ipa,"IP0" );
So you're saying that the above line is unnecessary...
Quoted 7 lines
drivers/clk/qcom/clk-rpmh.c static struct clk_hw *sm6350_rpmh_clocks[] = { · line 617
Quoted 7 lines
drivers/clk/qcom/clk-rpmh.c +1
-0static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_CXO_CLK ] = &sc7280_bi_tcxo.hw,@@ -613,6 +614,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_LN_BB_CLK3_A] = &sm6350_ln_bb_clk3_ao.hw, [RPMH_QLINK_CLK] = &sm6350_qlink.hw, [RPMH_QLINK_CLK_A] = &sm6350_qlink_ao.hw, + [RPMH_IPA_CLK] = &sm6350_ipa.hw,
...and that this line (above) can instead look like this:
[RPMH_IPA_CLK] = &sdm845_ipa.hw,
Correct?
Quoted 1 line
This can use sdm845_ipa.hw instead of defining new clocks.
Your statement seems to also be true for the [RPMH_IPA_CLK] entry in sdx55_rpmh_clocks[]. (For the record, the commit that added that one was authored by me, and I didn't realize what you have stated here.)
Please confirm, and I'll update.
I'll also send another patch to remove the definition of sdx55_ipa if Mani is willing to test it for me...
Thank you Dmitry.
-Alex
Quoted 8 lines
Quoted 6 lines
drivers/clk/qcom/clk-rpmh.c +0
-1};static const struct clk_rpmh_desc clk_rpmh_sm6350 = { --2.34.1
Quoted 13 lines · Alex Elder
Quoted 11 lines · Dmitry Baryshkov
Quoted 10 lines · Alex Elder
From: Luca Weiss <[email protected]>
The IPA core clock is required for SM6350. Define it.
Signed-off-by Luca Weiss <[email protected]>--- drivers/clk/qcom/clk-rpmh.c | 2 ++ 1 file changed, 2 insertions(+)
Quoted 11 lines
Quoted 9 lines
drivers/clk/qcom/clk-rpmh.c static const struct clk_rpmh_desc clk_rpmh_sc7280 = { · line 606
Quoted 9 lines
drivers/clk/qcom/clk-rpmh.c +1
-0@@ -603,6 +603,7 @@ static const struct clk_rpmh_desc clk_rpmh_sc7280 = {DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk2, ln_bb_clk2_ao,"lnbclkg2" ,4 );DEFINE_CLK_RPMH_VRM (sm6350, ln_bb_clk3, ln_bb_clk3_ao,"lnbclkg3" ,4 );DEFINE_CLK_RPMH_ARC (sm6350, qlink, qlink_ao,"qphy.lvl" ,0x1 ,4 ); +DEFINE_CLK_RPMH_BCM (sm6350, ipa,"IP0" );So you're saying that the above line is unnecessary...
Yes
Quoted 11 lines
Quoted 8 lines
drivers/clk/qcom/clk-rpmh.c static struct clk_hw *sm6350_rpmh_clocks[] = { · line 617
Quoted 8 lines
drivers/clk/qcom/clk-rpmh.c +1
-0static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_CXO_CLK ] = &sc7280_bi_tcxo.hw,@@ -613,6 +614,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { [RPMH_LN_BB_CLK3_A] = &sm6350_ln_bb_clk3_ao.hw, [RPMH_QLINK_CLK] = &sm6350_qlink.hw, [RPMH_QLINK_CLK_A] = &sm6350_qlink_ao.hw, + [RPMH_IPA_CLK] = &sm6350_ipa.hw,...and that this line (above) can instead look like this:
Quoted 3 lines
[RPMH_IPA_CLK] = &sdm845_ipa.hw,Correct?
Yes
Quoted 8 lines
Quoted 2 lines
This can use sdm845_ipa.hw instead of defining new clocks.
Your statement seems to also be true for the [
RPMH_IPA_CLK] entry in sdx55_rpmh_clocks[]. (For the record, the commit that added that one was authored by me, and I didn't realize what you have stated here.)
Quoted 18 lines
Please confirm, and I'll update.
I'll also send another patch to remove the definition of
sdx55_ipaif Mani is willing to test it for me...Thank you Dmitry.
-Alex
Quoted 8 lines
Quoted 6 lines
drivers/clk/qcom/clk-rpmh.c +0
-1};static const struct clk_rpmh_desc clk_rpmh_sm6350 = { --2.34.1
--
With best wishes
Dmitry