arm64: dts: imx8mp: Fix missing GPC Interrupt
Subsystems (2)
PATCH 1/2 arm64: dts: imx8mp: Fix missing GPC Interrupt
The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from dt_binding_check
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -0
@@ -524,6 +524,7 @@ gpc: gpc@303a0000 { compatible = "fsl,imx8mp-gpc"; reg = <0x303a0000 0x1000>; interrupt-parent = <&gic>; + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <3>;
Signature · 1 line
2.34.1
PATCH 2/2 arm64: dts: imx8mp: Fix power-domain typo
dt_binding_check detects an issue with the pgc_hsiomix power domain:
pgc: 'power-domains@17' does not match any of the regexes
This is because 'power-domains' should be 'power-domain'
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -1
@@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 { reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>; }; - pgc_hsiomix: power-domains@17 { + pgc_hsiomix: power-domain@17 { #power-domain-cells = <0>; reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>; clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
Signature · 1 line
2.34.1
Re: [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo
Hi Adam,
Thank you for the patch.
Quoted 5 lines · Adam Ford
dt_binding_checkdetects an issue with thepgc_hsiomixpower domain:
pgc: 'power-domains@17' does not match any of the regexesThis is because 'power-domains' should be 'power-domain'
Oops.
Quoted 16 lines
Fixes 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mp.dtsi +1
-1@@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 { reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>; }; - pgc_hsiomix: power-domains@17 { + pgc_hsiomix: power-domain@17 { #power-domain-cells = <0>; reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>; clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
Signature · 3 lines
Regards, Laurent Pinchart
Hi Adam,
Thank you for the patch.
Quoted 3 lines · Adam Ford
The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from
dt_binding_check
The interrupt isn't used by the driver as far as I can see, so I can't test this, but the patch matches the reference manual, so
Quoted 15 lines
Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mp.dtsi +1
-0@@ -524,6 +524,7 @@ gpc: gpc@303a0000 { compatible = "fsl,imx8mp-gpc"; reg = <0x303a0000 0x1000>; interrupt-parent = <&gic>; + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <3>;
Signature · 3 lines
Regards, Laurent Pinchart
Quoted 5 lines · Laurent Pinchart
Hi Adam,
Thank you for the patch.
Quoted 7 lines
Quoted 3 lines · Adam Ford
The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from
dt_binding_checkThe interrupt isn't used by the driver as far as I can see, so I can't test this, but the patch matches the reference manual, so
I don't think it changes functionality, but the other imx8m boards have it, and 'make dtbs_check' showed it as missing. Thanks for the review.
Quoted 23 lines
Reviewed-by Laurent Pinchart <[email protected]>Quoted 8 lines
Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")Signed-off-by Adam Ford <[email protected]>arch/arm64/boot/dts/freescale/imx8mp.dtsi +0
-0arch/arm64/boot/dts/freescale/imx8mp.dtsi gpc: gpc@303a0000 { · line 530
Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1
-0@@ -524,6 +524,7 @@ gpc: gpc@303a0000 { compatible = "fsl,imx8mp-gpc"; reg = <0x303a0000 0x1000>; interrupt-parent = <&gic>; + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; #interrupt-cells = <3>;--
Regards,Laurent Pinchart
Shawn Guo
AppliedQuoted 6 lines · Adam Ford
The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from
dt_binding_checkFixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")Signed-off-by Adam Ford <[email protected]>
Applied both, thanks!