Skip to contentSkip to conversation

arm64: dts: imx8mp: Fix missing GPC Interrupt

PATCH Applied Adam Ford 3 participants 6 messages Dec 17, 2022 – Jan 1, 2023

Subsystems (2)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH 1/2 arm64: dts: imx8mp: Fix missing GPC Interrupt

The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from dt_binding_check

Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -0
index 7a6e6221f421..7a8ca56e48b6 100644
@@ -524,6 +524,7 @@ gpc: gpc@303a0000 {
 				compatible = "fsl,imx8mp-gpc";
 				reg = <0x303a0000 0x1000>;
 				interrupt-parent = <&gic>;
+				interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-controller;
 				#interrupt-cells = <3>;
 
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/2 arm64: dts: imx8mp: Fix power-domain typo

dt_binding_check detects an issue with the pgc_hsiomix power domain:
pgc: 'power-domains@17' does not match any of the regexes

This is because 'power-domains' should be 'power-domain'

Fixes 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -1
index 7a8ca56e48b6..19609ef0560a 100644
@@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
 						reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
 					};
 
-					pgc_hsiomix: power-domains@17 {
+					pgc_hsiomix: power-domain@17 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
 						clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
Signature · 1 line
2.34.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: imx8mp: Fix power-domain typo

Hi Adam,

Thank you for the patch.

Quoted 5 lines · Adam Ford

dt_binding_check detects an issue with the pgc_hsiomix power domain:
pgc: 'power-domains@17' does not match any of the regexes

This is because 'power-domains' should be 'power-domain'

Oops.

Quoted 16 lines
Fixes 2ae42e0c0b67 ("arm64: dts: imx8mp: add HSIO power-domains")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -1
index 7a8ca56e48b6..19609ef0560a 100644
@@ -591,7 +591,7 @@ pgc_mipi_phy2: power-domain@16 {
 						reg = <IMX8MP_POWER_DOMAIN_MIPI_PHY2>;
 					};
 
-					pgc_hsiomix: power-domains@17 {
+					pgc_hsiomix: power-domain@17 {
 						#power-domain-cells = <0>;
 						reg = <IMX8MP_POWER_DOMAIN_HSIOMIX>;
 						clocks = <&clk IMX8MP_CLK_HSIO_AXI>,
Signature · 3 lines
Regards,

Laurent Pinchart
Reviewed-by on v1 1/2
#3 lore raw
In reply to Adam Ford

Hi Adam,

Thank you for the patch.

Quoted 3 lines · Adam Ford

The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from dt_binding_check

The interrupt isn't used by the driver as far as I can see, so I can't test this, but the patch matches the reference manual, so

Quoted 15 lines
Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -0
index 7a6e6221f421..7a8ca56e48b6 100644
@@ -524,6 +524,7 @@ gpc: gpc@303a0000 {
 				compatible = "fsl,imx8mp-gpc";
 				reg = <0x303a0000 0x1000>;
 				interrupt-parent = <&gic>;
+				interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
 				interrupt-controller;
 				#interrupt-cells = <3>;
 
Signature · 3 lines
Regards,

Laurent Pinchart
author
#4 lore raw
Quoted 5 lines · Laurent Pinchart

Hi Adam,

Thank you for the patch.

Quoted 7 lines
Quoted 3 lines · Adam Ford

The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from dt_binding_check

The interrupt isn't used by the driver as far as I can see, so I can't test this, but the patch matches the reference manual, so

I don't think it changes functionality, but the other imx8m boards have it, and 'make dtbs_check' showed it as missing. Thanks for the review.

Quoted 23 lines
Quoted 8 lines
Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")
arch/arm64/boot/dts/freescale/imx8mp.dtsi +0 -0
index 7a6e6221f421..7a8ca56e48b6 100644

arch/arm64/boot/dts/freescale/imx8mp.dtsi gpc: gpc@303a0000 { · line 530

Quoted 7 lines
arch/arm64/boot/dts/freescale/imx8mp.dtsi +1 -0
@@ -524,6 +524,7 @@ gpc: gpc@303a0000 {
                              compatible = "fsl,imx8mp-gpc";
                              reg = <0x303a0000 0x1000>;
                              interrupt-parent = <&gic>;
+                             interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
                              interrupt-controller;
                              #interrupt-cells = <3>;
 

--
Regards,

Laurent Pinchart

Applied
#5 lore raw
In reply to Adam Ford
Quoted 6 lines · Adam Ford

The GPC node references an interrupt parent, but it doesn't state the interrupt itself. According to the TRM, this IRQ is 87. This also eliminate an error detected from dt_binding_check

Fixes fc0f05124621 ("arm64: dts: imx8mp: add GPC node with GPU power domains")

Applied both, thanks!