Skip to contentSkip to conversation

dt-bindings: arm: Add Beacon EmbeddedWorks i.MX8M Plus kit

PATCH Superseded Adam Ford 2 participants 5 messages Dec 17, 2022 – Dec 19, 2022

Subsystems (2)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v2 1/2 dt-bindings: arm: Add Beacon EmbeddedWorks i.MX8M Plus kit

Add DT compatible string for a Beacon EmbeddedWorks development kit based on the i.MX8M Plus from NXP.

---
V2: Added Acked-by

Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
index 05b5276a0e14..4a92e0b2b890 100644
@@ -931,6 +931,7 @@ properties:
       - description: i.MX8MP based Boards
         items:
           - enum:
+              - beacon,imx8mp-beacon-kit  # i.MX8MP Beacon Development Kit
               - dh,imx8mp-dhcom-som       # i.MX8MP DHCOM SoM
               - dh,imx8mp-dhcom-pdk2      # i.MX8MP DHCOM SoM on PDK2 board
               - fsl,imx8mp-evk            # i.MX8MP EVK Board
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v2 2/2 arm64: dts: imx: Introduce imx8mp-beacon-kit

Beacon Embedded has an i.MX8M Plus development kit which consists of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet PHY.

---
V2: Fix whitespace, remove dead nodes, and fix some node and parameter names to address errors in 'make dt_binding_check'

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +549 -0
new file mode 100644
index 000000000000..70399f2419cf
@@ -0,0 +1,549 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/usb/pd.h>
+#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include "imx8mp.dtsi"
+#include "imx8mp-beacon-som.dtsi"
+
+/ {
+	model = "Beacon EmbeddedWorks i.MX8MPlus Development kit";
+	compatible = "beacon,imx8mp-beacon-kit", "fsl,imx8mp";
+
+	aliases {
+		ethernet0 = &eqos;
+		ethernet1 = &fec;
+	};
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	connector-1 {
+		compatible = "usb-c-connector";
+		label = "USB-C";
+		data-role = "dual";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			port@0 {
+				reg = <0>;
+				hs_ep: endpoint {
+					remote-endpoint = <&usb3_hs_ep>;
+				};
+			};
+			port@1 {
+				reg = <1>;
+				ss_ep: endpoint {
+					remote-endpoint = <&hd3ss3220_in_ep>;
+				};
+			};
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		autorepeat;
+
+		button-0 {
+			label = "btn0";
+			linux,code = <BTN_0>;
+			gpios = <&pca6416_1 12 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-1 {
+			label = "btn1";
+			linux,code = <BTN_1>;
+			gpios = <&pca6416_1 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-2 {
+			label = "btn2";
+			linux,code = <BTN_2>;
+			gpios = <&pca6416_1 14 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-3 {
+			label = "btn3";
+			linux,code = <BTN_3>;
+			gpios = <&pca6416_1 15 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led0 {
+			label = "gen_led0";
+			gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led1 {
+			label = "gen_led1";
+			gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led2 {
+			label = "gen_led2";
+			gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led3 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_led3>;
+			label = "heartbeat";
+			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+
+	pcie0_refclk: pcie0-refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <100000000>;
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		startup-delay-us = <100>;
+		off-on-delay-us = <20000>;
+	};
+
+	reg_usb1_host_vbus: regulator-usb1-vbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb1_host_vbus";
+		regulator-max-microvolt = <5000000>;
+		regulator-min-microvolt = <5000000>;
+		gpio = <&pca6416_1 0 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&ecspi2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_ecspi2>;
+	cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+	status = "okay";
+
+	tpm: tpm@0 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_tpm>;
+		compatible = "infineon,slb9670";
+		reg = <0>;
+		reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>;
+		spi-max-frequency = <18500000>;
+	};
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec>;
+	phy-mode = "rgmii-id";
+	phy-handle = <&ethphy1>;
+	phy-reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+	phy-reset-post-delay = <150>;
+	phy-reset-duration = <10>;
+	fsl,magic-packet;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy1: ethernet1-phy@3 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <3>;
+		};
+	};
+};
+
+&flexcan1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_flexcan1>;
+	status = "okay";
+};
+
+
+&i2c2 {
+	clock-frequency = <384000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+
+	pca6416_3: gpio-i2c2@20 {
+		compatible = "nxp,pcal6416";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
+
+&i2c3 {
+	/* Connected to USB Hub */
+	ptn5110: ptn5110@52 {
+		compatible = "nxp,ptn5110";
+		reg = <0x52>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_typec>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
+
+		connector {
+			compatible = "usb-c-connector";
+			label = "USB-C";
+			power-role = "source";
+			data-role = "host";
+			source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+		};
+	};
+};
+
+&i2c4 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c4>;
+	clock-frequency = <384000>;
+	status = "okay";
+
+	pca6416: gpio@20 {
+		compatible = "nxp,pcal6416";
+		reg = <0x20>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_pcal6414>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+
+	pca6416_1: gpio@21 {
+		compatible = "nxp,pcal6416";
+		reg = <0x21>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+
+		usb-hub-hog {
+			gpio-hog;
+			gpios = <7 GPIO_ACTIVE_LOW>;
+			output-low;
+			line-name = "USB Hub Enable";
+		};
+	};
+
+	hd3ss3220@47 {
+		compatible = "ti,hd3ss3220";
+		reg = <0x47>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_hd3ss3220>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			port@0 {
+				reg = <0>;
+				hd3ss3220_in_ep: endpoint {
+					remote-endpoint = <&ss_ep>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				hd3ss3220_out_ep: endpoint {
+					remote-endpoint = <&usb3_role_switch>;
+				};
+			};
+		};
+	};
+};
+
+&gpio2 {
+	usb-mux-hog {
+		gpio-hog;
+		gpios = <20 GPIO_ACTIVE_LOW>;
+		output-low;
+		line-name = "USB-C Mux En";
+	};
+};
+
+&pcie {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pcie>;
+	reset-gpio = <&gpio4 21 GPIO_ACTIVE_LOW>;
+	clocks = <&clk IMX8MP_CLK_HSIO_ROOT>,
+		 <&clk IMX8MP_CLK_PCIE_ROOT>,
+		 <&clk IMX8MP_CLK_HSIO_AXI>;
+	clock-names = "pcie", "pcie_aux", "pcie_bus";
+	assigned-clocks = <&clk IMX8MP_CLK_PCIE_AUX>;
+	assigned-clock-rates = <10000000>;
+	assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_50M>;
+	status = "okay";
+};
+
+&pcie_phy {
+	fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>;
+	clocks = <&pcie0_refclk>;
+	clock-names = "ref";
+	status = "okay";
+};
+
+&snvs_pwrkey {
+	status = "okay";
+};
+
+&uart2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart2>;
+	status = "okay";
+};
+
+&uart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	assigned-clocks = <&clk IMX8MP_CLK_UART3>;
+	assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_80M>;
+	fsl,uart-has-rtscts;
+	status = "okay";
+};
+
+&usb3_phy0 {
+	vbus-supply = <&reg_usb1_host_vbus>;
+	status = "okay";
+};
+
+&usb3_0 {
+	status = "okay";
+};
+
+&usb_dwc3_0 {
+	dr_mode = "otg";
+	hnp-disable;
+	srp-disable;
+	adp-disable;
+	usb-role-switch;
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		port@0 {
+			reg = <0>;
+			usb3_hs_ep: endpoint {
+				remote-endpoint = <&hs_ep>;
+			};
+		};
+		port@1 {
+			reg = <1>;
+			usb3_role_switch: endpoint {
+				remote-endpoint = <&hd3ss3220_out_ep>;
+			};
+		};
+	};
+};
+
+&usb3_phy1 {
+	status = "okay";
+};
+
+&usb3_1 {
+	status = "okay";
+};
+
+&usb_dwc3_1 {
+	dr_mode = "host";
+	status = "okay";
+};
+
+&usdhc2 {
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+	cd-gpios = <&gpio2 12 GPIO_ACTIVE_LOW>;
+	vmmc-supply = <&reg_usdhc2_vmmc>;
+	bus-width = <4>;
+	status = "okay";
+};
+
+&iomuxc {
+
+	pinctrl_ecspi2: ecspi2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK	0x82
+			MX8MP_IOMUXC_ECSPI2_MOSI__ECSPI2_MOSI	0x82
+			MX8MP_IOMUXC_ECSPI2_MISO__ECSPI2_MISO	0x82
+			MX8MP_IOMUXC_ECSPI2_SS0__GPIO5_IO13	0x40000
+		>;
+	};
+
+	pinctrl_fec: fecgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC	0x2
+			MX8MP_IOMUXC_SAI1_RXD3__ENET1_MDIO	0x2
+			MX8MP_IOMUXC_SAI1_RXD4__ENET1_RGMII_RD0	0x90
+			MX8MP_IOMUXC_SAI1_RXD5__ENET1_RGMII_RD1	0x90
+			MX8MP_IOMUXC_SAI1_RXD6__ENET1_RGMII_RD2	0x90
+			MX8MP_IOMUXC_SAI1_RXD7__ENET1_RGMII_RD3	0x90
+			MX8MP_IOMUXC_SAI1_TXC__ENET1_RGMII_RXC	0x90
+			MX8MP_IOMUXC_SAI1_TXFS__ENET1_RGMII_RX_CTL	0x90
+			MX8MP_IOMUXC_SAI1_TXD0__ENET1_RGMII_TD0	0x16
+			MX8MP_IOMUXC_SAI1_TXD1__ENET1_RGMII_TD1	0x16
+			MX8MP_IOMUXC_SAI1_TXD2__ENET1_RGMII_TD2	0x16
+			MX8MP_IOMUXC_SAI1_TXD3__ENET1_RGMII_TD3	0x16
+			MX8MP_IOMUXC_SAI1_TXD4__ENET1_RGMII_TX_CTL	0x16
+			MX8MP_IOMUXC_SAI1_TXD5__ENET1_RGMII_TXC	0x16
+			MX8MP_IOMUXC_SAI1_RXD0__GPIO4_IO02	0x10
+			MX8MP_IOMUXC_SAI1_TXD6__GPIO4_IO18	0x10
+		>;
+	};
+
+	pinctrl_flexcan1: flexcan1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SPDIF_RX__CAN1_RX	0x154
+			MX8MP_IOMUXC_SPDIF_TX__CAN1_TX	0x154
+		>;
+	};
+
+	pinctrl_hd3ss3220: hd3ss3220grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19	0x140
+		>;
+	};
+
+	pinctrl_i2c2: i2c2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C2_SCL__I2C2_SCL	0x400001c2
+			MX8MP_IOMUXC_I2C2_SDA__I2C2_SDA	0x400001c2
+		>;
+	};
+
+	pinctrl_i2c4: i2c4grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_I2C4_SCL__I2C4_SCL	0x400001c2
+			MX8MP_IOMUXC_I2C4_SDA__I2C4_SDA	0x400001c2
+		>;
+	};
+
+	pinctrl_led3: led3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28	0x41
+		>;
+	};
+
+	pinctrl_pcal6414: pcal6414-gpiogrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI2_MCLK__GPIO4_IO27	0x10
+		>;
+	};
+
+	pinctrl_pcie: pciegrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_GPIO1_IO05__GPIO1_IO05	0x10 /* PCIe_nDIS */
+			MX8MP_IOMUXC_SAI2_RXFS__GPIO4_IO21 0x10	/* PCIe_nRST */
+		>;
+	};
+
+	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_RESET_B__GPIO2_IO19	0x40
+		>;
+	};
+
+	pinctrl_tpm: tpmgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXFS__GPIO4_IO00	0x19 /* Reset */
+			MX8MP_IOMUXC_SAI3_RXC__GPIO4_IO29	0x1d6 /* IRQ */
+		>;
+	};
+
+	pinctrl_typec: typec1grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SAI1_RXC__GPIO4_IO01	0xc4
+		>;
+	};
+
+	pinctrl_uart2: uart2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX	0x140
+			MX8MP_IOMUXC_UART2_TXD__UART2_DCE_TX	0x140
+		>;
+	};
+
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_ECSPI1_SCLK__UART3_DCE_RX		0x140
+			MX8MP_IOMUXC_ECSPI1_MOSI__UART3_DCE_TX		0x140
+			MX8MP_IOMUXC_ECSPI1_SS0__UART3_DCE_RTS		0x140
+			MX8MP_IOMUXC_ECSPI1_MISO__UART3_DCE_CTS		0x140
+		>;
+	};
+
+	pinctrl_usdhc2: usdhc2grp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK	0x190
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD	0x1d0
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0	0x1d0
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1	0x1d0
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2	0x1d0
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3	0x1d0
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT	0xc0
+		>;
+	};
+
+	pinctrl_usdhc2_100mhz: usdhc2-100mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK	0x194
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD	0x1d4
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0	0x1d4
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1	0x1d4
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2	0x1d4
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3	0x1d4
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc0
+		>;
+	};
+
+	pinctrl_usdhc2_200mhz: usdhc2-200mhzgrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK	0x196
+			MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD	0x1d6
+			MX8MP_IOMUXC_SD2_DATA0__USDHC2_DATA0	0x1d6
+			MX8MP_IOMUXC_SD2_DATA1__USDHC2_DATA1	0x1d6
+			MX8MP_IOMUXC_SD2_DATA2__USDHC2_DATA2	0x1d6
+			MX8MP_IOMUXC_SD2_DATA3__USDHC2_DATA3	0x1d6
+			MX8MP_IOMUXC_GPIO1_IO04__USDHC2_VSELECT 0xc0
+		>;
+	};
+
+	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+		fsl,pins = <
+			MX8MP_IOMUXC_SD2_CD_B__GPIO2_IO12	0x1c4
+		>;
+	};
+};
arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi new file +416 -0

416 lines not on this page · raw message

Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH V2 2/2] arm64: dts: imx: Introduce imx8mp-beacon-kit

Quoted 10 lines · Adam Ford

Beacon Embedded has an i.MX8M Plus development kit which consists of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet PHY.

---
V2: Fix whitespace, remove dead nodes, and fix some node and parameter names to address errors in 'make dt_binding_check'

You still cannot check/test/build this DTS without Makefile.

Quoted 82 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +75 -0
new file mode 100644
index 000000000000..70399f2419cf
@@ -0,0 +1,549 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/usb/pd.h>
+#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include "imx8mp.dtsi"
+#include "imx8mp-beacon-som.dtsi"
+
+/ {
+	model = "Beacon EmbeddedWorks i.MX8MPlus Development kit";
+	compatible = "beacon,imx8mp-beacon-kit", "fsl,imx8mp";
+
+	aliases {
+		ethernet0 = &eqos;
+		ethernet1 = &fec;
+	};
+
+	chosen {
+		stdout-path = &uart2;
+	};
+
+	connector-1 {
+		compatible = "usb-c-connector";
+		label = "USB-C";
+		data-role = "dual";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			port@0 {
+				reg = <0>;
+				hs_ep: endpoint {
+					remote-endpoint = <&usb3_hs_ep>;
+				};
+			};
+			port@1 {
+				reg = <1>;
+				ss_ep: endpoint {
+					remote-endpoint = <&hd3ss3220_in_ep>;
+				};
+			};
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		autorepeat;
+
+		button-0 {
+			label = "btn0";
+			linux,code = <BTN_0>;
+			gpios = <&pca6416_1 12 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-1 {
+			label = "btn1";
+			linux,code = <BTN_1>;
+			gpios = <&pca6416_1 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-2 {
+			label = "btn2";
+			linux,code = <BTN_2>;
+			gpios = <&pca6416_1 14 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+
+		button-3 {
+			label = "btn3";

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 85

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +10 -0
+			linux,code = <BTN_3>;
+			gpios = <&pca6416_1 15 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+			wakeup-source;
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led0 {

No improvements here.

Quoted 95 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +95 -0
+			label = "gen_led0";
+			gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led1 {
+			label = "gen_led1";
+			gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led2 {
+			label = "gen_led2";
+			gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+			default-state = "off";
+		};
+
+		led3 {
+			pinctrl-names = "default";
+			pinctrl-0 = <&pinctrl_led3>;
+			label = "heartbeat";
+			gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "heartbeat";
+		};
+	};
+
+	pcie0_refclk: pcie0-refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <100000000>;
+	};
+
+	reg_usdhc2_vmmc: regulator-usdhc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "VSD_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+		startup-delay-us = <100>;
+		off-on-delay-us = <20000>;
+	};
+
+	reg_usb1_host_vbus: regulator-usb1-vbus {
+		compatible = "regulator-fixed";
+		regulator-name = "usb1_host_vbus";
+		regulator-max-microvolt = <5000000>;
+		regulator-min-microvolt = <5000000>;
+		gpio = <&pca6416_1 0 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+};
+
+&ecspi2 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_ecspi2>;
+	cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+	status = "okay";
+
+	tpm: tpm@0 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_tpm>;
+		compatible = "infineon,slb9670";
+		reg = <0>;
+		reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>;
+		spi-max-frequency = <18500000>;
+	};
+};
+
+&fec {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec>;
+	phy-mode = "rgmii-id";
+	phy-handle = <&ethphy1>;
+	phy-reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+	phy-reset-post-delay = <150>;
+	phy-reset-duration = <10>;
+	fsl,magic-packet;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy1: ethernet1-phy@3 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			reg = <3>;
+		};
+	};
+};
+
+&flexcan1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_flexcan1>;
+	status = "okay";

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 190

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +10 -0
+};
+
+
+&i2c2 {
+	clock-frequency = <384000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c2>;
+	status = "okay";
+
+	pca6416_3: gpio-i2c2@20 {

No improvements.

Quoted 4 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +4 -0
+		compatible = "nxp,pcal6416";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 204

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +10 -0
+		interrupt-parent = <&gpio4>;
+		interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+		interrupt-controller;
+		#interrupt-cells = <2>;
+	};
+};
+
+&i2c3 {
+	/* Connected to USB Hub */
+	ptn5110: ptn5110@52 {

No improvements ... I'll stop reviewing. No point if you do not intend to apply the comments.

Best regards,
Krzysztof

author
#3 lore raw

Re: [PATCH V2 2/2] arm64: dts: imx: Introduce imx8mp-beacon-kit

Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · Adam Ford

Beacon Embedded has an i.MX8M Plus development kit which consists of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet PHY.

Quoted 6 lines
Quoted 4 lines

---
V2: Fix whitespace, remove dead nodes, and fix some node and parameter names to address errors in 'make dt_binding_check'

You still cannot check/test/build this DTS without Makefile.

The lack of makefile was an honest mistake as I forgot to add it to my patch. I ran the make dt_binding_check and addressed many of the errors, but some of them are not unique to my board, because they were errors in the imx8mp.dtsi file. I addressed some of them by sending patches to fix some types in imx8mp.dtsi. I will make sure V3 has the makefile updated.

Quoted 87 lines
Quoted 87 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +79 -0
new file mode 100644
index 000000000000..70399f2419cf
@@ -0,0 +1,549 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/usb/pd.h>
+#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include "imx8mp.dtsi"
+#include "imx8mp-beacon-som.dtsi"
+
+/ {
+     model = "Beacon EmbeddedWorks i.MX8MPlus Development kit";
+     compatible = "beacon,imx8mp-beacon-kit", "fsl,imx8mp";
+
+     aliases {
+             ethernet0 = &eqos;
+             ethernet1 = &fec;
+     };
+
+     chosen {
+             stdout-path = &uart2;
+     };
+
+     connector-1 {
+             compatible = "usb-c-connector";
+             label = "USB-C";
+             data-role = "dual";
+
+             ports {
+                     #address-cells = <1>;
+                     #size-cells = <0>;
+                     port@0 {
+                             reg = <0>;
+                             hs_ep: endpoint {
+                                     remote-endpoint = <&usb3_hs_ep>;
+                             };
+                     };
+                     port@1 {
+                             reg = <1>;
+                             ss_ep: endpoint {
+                                     remote-endpoint = <&hd3ss3220_in_ep>;
+                             };
+                     };
+             };
+     };
+
+     gpio-keys {
+             compatible = "gpio-keys";
+             autorepeat;
+
+             button-0 {
+                     label = "btn0";
+                     linux,code = <BTN_0>;
+                     gpios = <&pca6416_1 12 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-1 {
+                     label = "btn1";
+                     linux,code = <BTN_1>;
+                     gpios = <&pca6416_1 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-2 {
+                     label = "btn2";
+                     linux,code = <BTN_2>;
+                     gpios = <&pca6416_1 14 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-3 {
+                     label = "btn3";
+                     linux,code = <BTN_3>;
+                     gpios = <&pca6416_1 15 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 85

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +6 -0
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             led0 {

No improvements here.

I forgot the git commit --amend so my patch was missing the changes, but my machine has the fix. Sorry about that.

Quoted 100 lines
Quoted 100 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +99 -0
+                     label = "gen_led0";
+                     gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led1 {
+                     label = "gen_led1";
+                     gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led2 {
+                     label = "gen_led2";
+                     gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led3 {
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&pinctrl_led3>;
+                     label = "heartbeat";
+                     gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+                     linux,default-trigger = "heartbeat";
+             };
+     };
+
+     pcie0_refclk: pcie0-refclk {
+             compatible = "fixed-clock";
+             #clock-cells = <0>;
+             clock-frequency = <100000000>;
+     };
+
+     reg_usdhc2_vmmc: regulator-usdhc2 {
+             compatible = "regulator-fixed";
+             regulator-name = "VSD_3V3";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+             startup-delay-us = <100>;
+             off-on-delay-us = <20000>;
+     };
+
+     reg_usb1_host_vbus: regulator-usb1-vbus {
+             compatible = "regulator-fixed";
+             regulator-name = "usb1_host_vbus";
+             regulator-max-microvolt = <5000000>;
+             regulator-min-microvolt = <5000000>;
+             gpio = <&pca6416_1 0 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+};
+
+&ecspi2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_ecspi2>;
+     cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+     status = "okay";
+
+     tpm: tpm@0 {
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_tpm>;
+             compatible = "infineon,slb9670";
+             reg = <0>;
+             reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>;
+             spi-max-frequency = <18500000>;
+     };
+};
+
+&fec {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_fec>;
+     phy-mode = "rgmii-id";
+     phy-handle = <&ethphy1>;
+     phy-reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+     phy-reset-post-delay = <150>;
+     phy-reset-duration = <10>;
+     fsl,magic-packet;
+     status = "okay";
+
+     mdio {
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             ethphy1: ethernet1-phy@3 {
+                     compatible = "ethernet-phy-ieee802.3-c22";
+                     reg = <3>;
+             };
+     };
+};
+
+&flexcan1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_flexcan1>;
+     status = "okay";
+};
+
+
+&i2c2 {
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 190

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +6 -0
+     clock-frequency = <384000>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_i2c2>;
+     status = "okay";
+
+     pca6416_3: gpio-i2c2@20 {

No improvements.

I am not sure what I am supposed to do here. I already have one node called "gpio@20" and as far as I know, I can't have duplicate nodes with the same name. I have the same GPIO expander with the same on a different i2c bus. Do you have a recommendation as to what name I should use so the names are unique?

Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +9 -0
+             compatible = "nxp,pcal6416";
+             reg = <0x20>;
+             gpio-controller;
+             #gpio-cells = <2>;
+             interrupt-parent = <&gpio4>;
+             interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+             interrupt-controller;
+             #interrupt-cells = <2>;
+     };
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 204

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +5 -0
+};
+
+&i2c3 {
+     /* Connected to USB Hub */
+     ptn5110: ptn5110@52 {

No improvements ... I'll stop reviewing. No point if you do not intend to apply the comments.

I changed this node from tcpc to ptn5110 per your last comment, and it matches other boards that use this and Documentation/devicetree/bindings/connector/usb-connector.yaml example uses ptn5110. Documentation/devicetree/bindings/usb/typec-tcpci.txt just called it "ptn5110@50" .

imx8mm-evk.dtsi calls it "ptn5110: tcpc@50" so that's the example I followed. I am guessing it fails the build test because there isn't a yaml file for this driver.

I wasn't intentionally ignoring your comments, and I honestly tried to catch them.

If you let me know how you want me to proceed, I will do a V3.

thank you,

adam

Quoted 5 lines

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH V2 2/2] arm64: dts: imx: Introduce imx8mp-beacon-kit

Quoted 256 lines · Adam Ford
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · Adam Ford

Beacon Embedded has an i.MX8M Plus development kit which consists of a SOM + baseboard. The SOM includes Bluetooth, WiFi, QSPI, eMMC, and one Ethernet PHY. The baseboard includes audio, HDMI, USB-C Dual Role port, USB Hub with five ports, a PCIe slot, and a second Ethernet PHY.

Quoted 6 lines
Quoted 4 lines

---
V2: Fix whitespace, remove dead nodes, and fix some node and parameter names to address errors in 'make dt_binding_check'

You still cannot check/test/build this DTS without Makefile.

The lack of makefile was an honest mistake as I forgot to add it to my patch. I ran the make dt_binding_check and addressed many of the errors, but some of them are not unique to my board, because they were errors in the imx8mp.dtsi file. I addressed some of them by sending patches to fix some types in imx8mp.dtsi. I will make sure V3 has the makefile updated.

Quoted 87 lines
Quoted 87 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +79 -0
new file mode 100644
index 000000000000..70399f2419cf
@@ -0,0 +1,549 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2022 Logic PD, Inc dba Beacon EmbeddedWorks
+ */
+
+/dts-v1/;
+
+#include <dt-bindings/usb/pd.h>
+#include <dt-bindings/phy/phy-imx8-pcie.h>
+#include "imx8mp.dtsi"
+#include "imx8mp-beacon-som.dtsi"
+
+/ {
+     model = "Beacon EmbeddedWorks i.MX8MPlus Development kit";
+     compatible = "beacon,imx8mp-beacon-kit", "fsl,imx8mp";
+
+     aliases {
+             ethernet0 = &eqos;
+             ethernet1 = &fec;
+     };
+
+     chosen {
+             stdout-path = &uart2;
+     };
+
+     connector-1 {
+             compatible = "usb-c-connector";
+             label = "USB-C";
+             data-role = "dual";
+
+             ports {
+                     #address-cells = <1>;
+                     #size-cells = <0>;
+                     port@0 {
+                             reg = <0>;
+                             hs_ep: endpoint {
+                                     remote-endpoint = <&usb3_hs_ep>;
+                             };
+                     };
+                     port@1 {
+                             reg = <1>;
+                             ss_ep: endpoint {
+                                     remote-endpoint = <&hd3ss3220_in_ep>;
+                             };
+                     };
+             };
+     };
+
+     gpio-keys {
+             compatible = "gpio-keys";
+             autorepeat;
+
+             button-0 {
+                     label = "btn0";
+                     linux,code = <BTN_0>;
+                     gpios = <&pca6416_1 12 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-1 {
+                     label = "btn1";
+                     linux,code = <BTN_1>;
+                     gpios = <&pca6416_1 13 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-2 {
+                     label = "btn2";
+                     linux,code = <BTN_2>;
+                     gpios = <&pca6416_1 14 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
+
+             button-3 {
+                     label = "btn3";
+                     linux,code = <BTN_3>;
+                     gpios = <&pca6416_1 15 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
+                     wakeup-source;
+             };
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 85

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +6 -0
+     };
+
+     leds {
+             compatible = "gpio-leds";
+
+             led0 {

No improvements here.

I forgot the git commit --amend so my patch was missing the changes, but my machine has the fix. Sorry about that.

Quoted 100 lines
Quoted 100 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +99 -0
+                     label = "gen_led0";
+                     gpios = <&pca6416_1 4 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led1 {
+                     label = "gen_led1";
+                     gpios = <&pca6416_1 5 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led2 {
+                     label = "gen_led2";
+                     gpios = <&pca6416_1 6 GPIO_ACTIVE_HIGH>;
+                     default-state = "off";
+             };
+
+             led3 {
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&pinctrl_led3>;
+                     label = "heartbeat";
+                     gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+                     linux,default-trigger = "heartbeat";
+             };
+     };
+
+     pcie0_refclk: pcie0-refclk {
+             compatible = "fixed-clock";
+             #clock-cells = <0>;
+             clock-frequency = <100000000>;
+     };
+
+     reg_usdhc2_vmmc: regulator-usdhc2 {
+             compatible = "regulator-fixed";
+             regulator-name = "VSD_3V3";
+             regulator-min-microvolt = <3300000>;
+             regulator-max-microvolt = <3300000>;
+             gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+             startup-delay-us = <100>;
+             off-on-delay-us = <20000>;
+     };
+
+     reg_usb1_host_vbus: regulator-usb1-vbus {
+             compatible = "regulator-fixed";
+             regulator-name = "usb1_host_vbus";
+             regulator-max-microvolt = <5000000>;
+             regulator-min-microvolt = <5000000>;
+             gpio = <&pca6416_1 0 GPIO_ACTIVE_HIGH>;
+             enable-active-high;
+     };
+};
+
+&ecspi2 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_ecspi2>;
+     cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
+     status = "okay";
+
+     tpm: tpm@0 {
+             pinctrl-names = "default";
+             pinctrl-0 = <&pinctrl_tpm>;
+             compatible = "infineon,slb9670";
+             reg = <0>;
+             reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>;
+             spi-max-frequency = <18500000>;
+     };
+};
+
+&fec {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_fec>;
+     phy-mode = "rgmii-id";
+     phy-handle = <&ethphy1>;
+     phy-reset-gpios = <&gpio4 18 GPIO_ACTIVE_LOW>;
+     phy-reset-post-delay = <150>;
+     phy-reset-duration = <10>;
+     fsl,magic-packet;
+     status = "okay";
+
+     mdio {
+             #address-cells = <1>;
+             #size-cells = <0>;
+
+             ethphy1: ethernet1-phy@3 {
+                     compatible = "ethernet-phy-ieee802.3-c22";
+                     reg = <3>;
+             };
+     };
+};
+
+&flexcan1 {
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_flexcan1>;
+     status = "okay";
+};
+
+
+&i2c2 {
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 190

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +6 -0
+     clock-frequency = <384000>;
+     pinctrl-names = "default";
+     pinctrl-0 = <&pinctrl_i2c2>;
+     status = "okay";
+
+     pca6416_3: gpio-i2c2@20 {

No improvements.

I am not sure what I am supposed to do here. I already have one node called "gpio@20" and as far as I know, I can't have duplicate nodes with the same name. I have the same GPIO expander with the same on a different i2c bus. Do you have a recommendation as to what name I should use so the names are unique?

Quoted 10 lines
Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +9 -0
+             compatible = "nxp,pcal6416";
+             reg = <0x20>;
+             gpio-controller;
+             #gpio-cells = <2>;
+             interrupt-parent = <&gpio4>;
+             interrupts = <27 IRQ_TYPE_EDGE_FALLING>;
+             interrupt-controller;
+             #interrupt-cells = <2>;
+     };
Quoted 8 lines

arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts line 204

Quoted 5 lines
arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts new file +5 -0
+};
+
+&i2c3 {
+     /* Connected to USB Hub */
+     ptn5110: ptn5110@52 {

No improvements ... I'll stop reviewing. No point if you do not intend to apply the comments.

Quoted 6 lines

I changed this node from tcpc to ptn5110 per your last comment, and it matches other boards that use this and Documentation/devicetree/bindings/connector/usb-connector.yaml example uses ptn5110. Documentation/devicetree/bindings/usb/typec-tcpci.txt just called it "ptn5110@50" .

My comment was that node name has to be generic. ptn5110 is not generic but specific. I gave you reference to examples of generic names but in other boards there are more examples how this could be named.

Quoted 9 lines

imx8mm-evk.dtsi calls it "ptn5110: tcpc@50" so that's the example I followed. I am guessing it fails the build test because there isn't a yaml file for this driver.

I wasn't intentionally ignoring your comments, and I honestly tried to catch them.

If you let me know how you want me to proceed, I will do a V3.

I stopped reviewing. Implement all the comments but if something is not clear, just ask for clarification.

Best regards,
Krzysztof