drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC
Subsystems (3)
PATCH v2 1/1 drm: rcar-du: depend on DRM_RCAR_DU for components on that SoC
There's a few components in the rcar-du drm directory that don't make sense to be selectable if DRM_RCAR_DU isn't because they are part of the IP block so add a dependency and add compile check to ensure they're still tested.
---
v2:
- typo fix in commit message
- s/ARCH_RENESAS/DRM_RCAR_DU
drivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/rcar-du/Kconfig +3 -0
@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on DRM_RCAR_DU || COMPILE_TEST select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.
@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Signature · 1 line
2.39.0
Hi Peter,
Thank you for the patch.
Quoted 20 lines · Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be selectable if
DRM_RCAR_DUisn't because they are part of the IP block so add a dependency and add compile check to ensure they're still tested.Signed-off-by Peter Robinson <[email protected]>---
v2:
- typo fix in commit message
- s/ARCH_RENESAS/DRM_RCAR_DUdrivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/rcar-du/Kconfig +0
-0
drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_CMM · line 28
Quoted 4 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on DRM_RCAR_DU || COMPILE_TEST
How about dropping COMPILE_TEST ? DRM_RCAR_DU itself has
depends on ARCH_RENESAS || COMPILE_TEST
so if COMPILE_TEST is set we'll be able to test these drivers when DRM_RCAR_DU is enabled. Same below.
I can update this when taking the patch in my tree, there's no need to send a v3.
Quoted 19 lines
drivers/gpu/drm/rcar-du/Kconfig +2
-0select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 33 lines · Laurent Pinchart
Hi Peter,
Thank you for the patch.
Quoted 20 lines · Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be selectable if
DRM_RCAR_DUisn't because they are part of the IP block so add a dependency and add compile check to ensure they're still tested.Signed-off-by Peter Robinson <[email protected]>---
v2:
- typo fix in commit message
- s/ARCH_RENESAS/DRM_RCAR_DUdrivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/rcar-du/Kconfig +0
-0drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_CMM · line 28
Quoted 4 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on DRM_RCAR_DU || COMPILE_TESTHow about dropping
COMPILE_TEST?DRM_RCAR_DUitself has
Quoted 7 lines
depends on ARCH_RENESAS || COMPILE_TESTso if
COMPILE_TESTis set we'll be able to test these drivers whenDRM_RCAR_DUis enabled. Same below.I can update this when taking the patch in my tree, there's no need to send a v3.
Works for me! Thanks
Quoted 24 lines
Quoted 12 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_LVDS · line 53
Quoted 7 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on DRM_RCAR_DU || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.--
Regards,Laurent Pinchart