drm: rcar-du: depend on ARCH_RENESAS for components on that SoC
Subsystems (3)
PATCH 1/1 drm: rcar-du: depend on ARCH_RENESAS for components on that SoC
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if ARCH_RENESAS isn't because they are part of those SoCs so add a dependency and add compile check to ensure they're still tested.
--- drivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/rcar-du/Kconfig +3 -0
@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on ARCH_RENESAS || COMPILE_TEST select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.
@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.
@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Signature · 1 line
2.39.0
Hi Peter,
Thank you for the patch.
Quoted 2 lines · Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if
ARCH_RENESASisn't because
s/slectedable/selectable/
Quoted 13 lines
they are part of those SoCs so add a dependency and add compile check to ensure they're still tested.
Signed-off-by Peter Robinson <[email protected]>--- drivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/rcar-du/Kconfig +0
-0
drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_CMM · line 28
Quoted 4 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on ARCH_RENESAS || COMPILE_TEST
As this module isn't useful without the DU driver, wouldn't it be better to add a dependency on DRM_RCAR_DU, which itself already depends on ARCH_RENESAS || COMPILE_TEST ? Same for the other two below.
Quoted 19 lines
drivers/gpu/drm/rcar-du/Kconfig +2
-0select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Signature · 3 lines
Regards, Laurent Pinchart
Hi Laurent,
Quoted 16 lines
Thank you for the patch.
Quoted 2 lines · Peter Robinson
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if
ARCH_RENESASisn't becauses/slectedable/selectable/
Quoted 8 lines
they are part of those SoCs so add a dependency and add compile check to ensure they're still tested.
Signed-off-by Peter Robinson <[email protected]>--- drivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)
Quoted 13 lines
drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_CMM · line 28
Quoted 9 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on ARCH_RENESAS || COMPILE_TESTAs this module isn't useful without the DU driver, wouldn't it be better to add a dependency on
DRM_RCAR_DU, which itself already depends onARCH_RENESAS||COMPILE_TEST? Same for the other two below.
I had considered both options but as I suspected that it would have at least been compile tested by I wasn't 100% sure of the dependency within the actually SoC as I don't really know the HW but I am happy to go that route too.
Also the DRM_RCAR_USE_ options seem a little weird too the DRM_RCAR_USE_MIPI_DSI vs just using DRM_RCAR_MIPI_DSI, seems like extra logic just in the Kconfig that provides little, but ultimately that bit doesn't affect me overall.
Will do a v2
Peter
Quoted 24 lines
Quoted 12 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_LVDS · line 53
Quoted 7 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.--
Regards,Laurent Pinchart
Hi Peter,
Quoted 28 lines · Peter Robinson
Quoted 14 lines · Peter Robinson
Quoted 2 lines
There's a few components in the rcar-du drm directory that don't make sense to be slectedable if
ARCH_RENESASisn't becauses/slectedable/selectable/
Quoted 8 lines
they are part of those SoCs so add a dependency and add compile check to ensure they're still tested.
Signed-off-by Peter Robinson <[email protected]>--- drivers/gpu/drm/rcar-du/Kconfig | 3 +++ 1 file changed, 3 insertions(+)Quoted 13 lines
drivers/gpu/drm/rcar-du/Kconfig config DRM_RCAR_CMM · line 28
Quoted 9 lines
drivers/gpu/drm/rcar-du/Kconfig +1
-0@@ -25,6 +25,7 @@ config DRM_RCAR_CMM config DRM_RCAR_DW_HDMI tristate "R-Car Gen3 and RZ/G2 DU HDMI Encoder Support" depends on DRM && OF + depends on ARCH_RENESAS || COMPILE_TESTAs this module isn't useful without the DU driver, wouldn't it be better to add a dependency on
DRM_RCAR_DU, which itself already depends onARCH_RENESAS||COMPILE_TEST? Same for the other two below.
Quoted 4 lines
I had considered both options but as I suspected that it would have at least been compile tested by I wasn't 100% sure of the dependency within the actually SoC as I don't really know the HW but I am happy to go that route too.
No worries. I can confirm that the extra drivers can't be used without the DU.
Quoted 4 lines
Also the
DRM_RCAR_USE_options seem a little weird too theDRM_RCAR_USE_MIPI_DSIvs just usingDRM_RCAR_MIPI_DSI, seems like extra logic just in theKconfigthat provides little, but ultimately that bit doesn't affect me overall.
Yes it's awkward. The reason for this is that the DU drivers call into the RCAR_CMM, RCAR_LVDS and RCAR_MIPI_DSI drivers directly. They are however optional, so the functions are stubbed with IS_ENABLED() using the corresponding CONFIG_DRM_RCAR_* Kconfig symbol, but Kconfig doesn't make it easy to express the dependencies correctly in that case. Other options have been tried, causing build problems in one way or another (you can check the git log if curious).
Quoted 1 line
Will do a v2
Thank you.
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
drivers/gpu/drm/rcar-du/Kconfig +2
-0select DRM_DW_HDMI help Enable support for R-Car Gen3 or RZ/G2 internal HDMI encoder.@@ -32,6 +33,7 @@ config DRM_RCAR_DW_HDMI config DRM_RCAR_USE_LVDS bool "R-Car DU LVDS Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded LVDS encoders.@@ -45,6 +47,7 @@ config DRM_RCAR_LVDS config DRM_RCAR_USE_MIPI_DSI bool "R-Car DU MIPI DSI Encoder Support" depends on DRM_BRIDGE && OF + depends on ARCH_RENESAS || COMPILE_TEST default DRM_RCAR_DU help Enable support for the R-Car Display Unit embedded MIPI DSI encoders.
Signature · 3 lines
Regards, Laurent Pinchart