Skip to contentSkip to conversation

ps3vram: remove bio splitting

PATCH Applied Christoph Hellwig 3 participants 3 messages Jan 23, 2023 – Jan 24, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ps3vram: remove bio splitting

ps3vram iterates over the bio one segment, that is page aligned and max page sized chunk, a time. Because of that there is no point in calling bio_split_to_limits, or explicitly setting the default limits that are only used by bio_split_to_limits.

---
 drivers/block/ps3vram.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/block/ps3vram.c +0 -7
index 574e470b220b09..38d42af01b2535 100644
@@ -586,10 +586,6 @@ static void ps3vram_submit_bio(struct bio *bio)
 
 	dev_dbg(&dev->core, "%s\n", __func__);
 
-	bio = bio_split_to_limits(bio);
-	if (!bio)
-		return;
-
 	spin_lock_irq(&priv->lock);
 	busy = !bio_list_empty(&priv->list);
 	bio_list_add(&priv->list, bio);
@@ -749,9 +745,6 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev)
 	gendisk->private_data = dev;
 	strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name));
 	set_capacity(gendisk, priv->size >> 9);
-	blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS);
-	blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE);
-	blk_queue_max_hw_sectors(gendisk->queue, BLK_SAFE_MAX_SECTORS);
 
 	dev_info(&dev->core, "%s: Using %llu MiB of GPU memory\n",
 		 gendisk->disk_name, get_capacity(gendisk) >> 11);
Signature · 1 line
2.39.0
maintainer Tested-by on v1 1/1
#1 lore raw

Hi Christoph,

Quoted 9 lines · Christoph Hellwig

ps3vram iterates over the bio one segment, that is page aligned and max page sized chunk, a time. Because of that there is no point in calling bio_split_to_limits, or explicitly setting the default limits that are only used by bio_split_to_limits.

---
 drivers/block/ps3vram.c | 7 -------
 1 file changed, 7 deletions(-)

I tested this patch applied to the ps3-queue branch (v6.2-rc5 based) of my kernel.org ps3-linux repo. I could format the ps3vram device with ext4, copy files to it, run fsck, etc.

Thanks for your effort.

maintainer Applied
#2 lore raw
In reply to Christoph Hellwig
Quoted 6 lines · Christoph Hellwig

ps3vram iterates over the bio one segment, that is page aligned and max page sized chunk, a time. Because of that there is no point in calling bio_split_to_limits, or explicitly setting the default limits that are only used by bio_split_to_limits.

Applied, thanks!

[1/1] ps3vram: remove bio splitting

      commit: 2192a93eb4ac63eeb37ec5ec5cfa0db92ded5e3c

Best regards,

Signature · 1 line
Jens Axboe