Skip to contentSkip to conversation

docs/about/deprecated: Mark HAXM as deprecated

PATCH Superseded Thomas Huth 3 participants 4 messages Jan 25, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/about/deprecated: Mark HAXM as deprecated

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

---
 docs/about/deprecated.rst | 6 ++++++
 1 file changed, 6 insertions(+)
docs/about/deprecated.rst +6 -0
index 3f4d678eb4..da2e6fe63d 100644
@@ -93,6 +93,12 @@ form is preferred.
 The HPET setting has been turned into a machine property.
 Use ``-machine hpet=off`` instead.
 
+``-accel hax`` (since 8.0)
+''''''''''''''''''''''''''
+
+The HAXM project has been retired (see https://github.com/intel/haxm#status).
+Use "whpx" (on Windows) or "hvf" (on macOS) instead.
+
 
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thomas Huth

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

---
  docs/about/deprecated.rst | 6 ++++++
  1 file changed, 6 insertions(+)
#2 lore raw
In reply to Thomas Huth
Quoted 15 lines · Thomas Huth

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

---
 docs/about/deprecated.rst | 6 ++++++
 1 file changed, 6 insertions(+)
docs/about/deprecated.rst +0 -0
index 3f4d678eb4..da2e6fe63d 100644

docs/about/deprecated.rst form is preferred. · line 101

Quoted 9 lines
docs/about/deprecated.rst +6 -0
@@ -93,6 +93,12 @@ form is preferred.
 The HPET setting has been turned into a machine property.
 Use ``-machine hpet=off`` instead.
 
+``-accel hax`` (since 8.0)
+''''''''''''''''''''''''''
+
+The HAXM project has been retired (see https://github.com/intel/haxm#status).
+Use "whpx" (on Windows) or "hvf" (on macOS) instead.
+

Should we print a warning message from meson when someone enables this ?

We've tended to do that when we've deprecated other platforms in the past, though not consistently

Quoted 6 lines
docs/about/deprecated.rst +0 -0
 QEMU Machine Protocol (QMP) commands
 ------------------------------------
Signature · 1 line
2.31.1

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#3 lore raw
Quoted 19 lines · Daniel P. Berrangé
Quoted 18 lines · Thomas Huth

The HAXM project has been retired (see https://github.com/intel/haxm#status),
so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too).

---
  docs/about/deprecated.rst | 6 ++++++
  1 file changed, 6 insertions(+)
docs/about/deprecated.rst +0 -0
index 3f4d678eb4..da2e6fe63d 100644
@@ -93,6 +93,12 @@ form is preferred.
  The HPET setting has been turned into a machine property.
  Use ``-machine hpet=off`` instead.
 
Quoted 8 lines

docs/about/deprecated.rst form is preferred. · line 101

Quoted 6 lines
docs/about/deprecated.rst +6 -0
+``-accel hax`` (since 8.0)
+''''''''''''''''''''''''''
+
+The HAXM project has been retired (see https://github.com/intel/haxm#status).
+Use "whpx" (on Windows) or "hvf" (on macOS) instead.
+

Should we print a warning message from meson when someone enables this ?

Or maybe rather to hax_accel_init() , so that people who run the binary see the message?

... I can add it there (though I have no means of testing it).

Thomas