Skip to contentSkip to conversation

virtio-net: Avoid confusing device configuration text

PATCH In review Parav Pandit 3 participants 3 messages Jan 26, 2023 – Jan 30, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-net: Avoid confusing device configuration text

The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.

Hence remove it as discussed in [1] and [2].

[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.html

Fixes 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")

---
This change is on top of [3].

[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html

---
 device-types/net/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
device-types/net/description.tex +1 -1
index e32780b..bd81731 100644
@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering}
 
 When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST
-accept all VLAN tagged packets as per the device configuration.
+accept all VLAN tagged packets.
 
 When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST
 accept all VLAN tagged packets whose VLAN tag is present in
Signature · 1 line
2.26.2
#1 lore raw
Quoted 24 lines · Parav Pandit

The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.

Hence remove it as discussed in [1] and [2].

[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.html

Fixes 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")

---
This change is on top of [3].

[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html

---
 device-types/net/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
device-types/net/description.tex +0 -0
index e32780b..bd81731 100644

device-types/net/description.tex \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi · line 1229

Quoted 8 lines
device-types/net/description.tex +1 -1
@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering}
 
 When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST
-accept all VLAN tagged packets as per the device configuration.
+accept all VLAN tagged packets.
 
 When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST
 accept all VLAN tagged packets whose VLAN tag is present in

I think I can apply this on top of [3] as an editorial change when applying that, but can I please get some kind of ack/r-b on this change?

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Acked-by on v1 1/1
#2 lore raw
In reply to Parav Pandit
Quoted 11 lines · Parav Pandit

The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.

Hence remove it as discussed in [1] and [2].

[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.html

Fixes 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")

I agree it's an editorial change.

Quoted 23 lines

---
This change is on top of [3].

[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html

---
 device-types/net/description.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
device-types/net/description.tex +1 -1
index e32780b..bd81731 100644
@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
 \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering}
 
 When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST
-accept all VLAN tagged packets as per the device configuration.
+accept all VLAN tagged packets.
 
 When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST
 accept all VLAN tagged packets whose VLAN tag is present in
Signature · 1 line
2.26.2