virtio-net: Avoid confusing device configuration text
PATCH 1/1 virtio-net: Avoid confusing device configuration text
The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.
Hence remove it as discussed in [1] and [2].
[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.html
---
This change is on top of [3].
[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html
--- device-types/net/description.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
device-types/net/description.tex +1 -1
@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering} When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST -accept all VLAN tagged packets as per the device configuration. +accept all VLAN tagged packets. When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST accept all VLAN tagged packets whose VLAN tag is present in
Signature · 1 line
2.26.2
Quoted 24 lines · Parav Pandit
The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.
Hence remove it as discussed in [1] and [2].
[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.htmlFixes 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")Suggested-by Halil Pasic <[email protected]>Signed-off-by Parav Pandit <[email protected]>---
This change is on top of [3].[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html
--- device-types/net/description.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)device-types/net/description.tex +0
-0
device-types/net/description.tex \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi · line 1229
Quoted 8 lines
device-types/net/description.tex +1
-1@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering} When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST -accept all VLAN tagged packets as per the device configuration. +accept all VLAN tagged packets. When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST accept all VLAN tagged packets whose VLAN tag is present in
I think I can apply this on top of [3] as an editorial change when applying that, but can I please get some kind of ack/r-b on this change?
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Quoted 11 lines · Parav Pandit
The added text in commit of Fixes tag was redundant and confusing in context of VLAN filtering description.
Hence remove it as discussed in [1] and [2].
[1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html
[2] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00286.htmlFixes 296303444f6b ("virtio-net: Clarify VLAN filter table configuration")Suggested-by Halil Pasic <[email protected]>Signed-off-by Parav Pandit <[email protected]>
I agree it's an editorial change.
Quoted 23 lines
---
This change is on top of [3].[3] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00231.html
--- device-types/net/description.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)device-types/net/description.tex +1
-1@@ -1223,7 +1223,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi \devicenormative{\subparagraph}{VLAN Filtering}{Device Types / Network Device / Device Operation / Control Virtqueue / VLAN Filtering} When VIRTIO_NET_F_CTRL_VLAN is not negotiated, the device MUST -accept all VLAN tagged packets as per the device configuration. +accept all VLAN tagged packets. When VIRTIO_NET_F_CTRL_VLAN is negotiated, the device MUST accept all VLAN tagged packets whose VLAN tag is present inSignature · 1 line
2.26.2