Skip to contentSkip to conversation

lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()

PATCH Applied Tom Rix 3 participants 3 messages Jan 28, 2023 – Jan 30, 2023

lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()

cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]

    size_t avail_in = avail_in = strm->avail_in;

Only setting avail_in once is needed.

Fixes aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
---
 lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/zlib_dfltcc/dfltcc_deflate.c +1 -1
index 80924f067c24..b732b6d9e35d 100644
@@ -62,7 +62,7 @@ static void dfltcc_gdht(
 {
     deflate_state *state = (deflate_state *)strm->state;
     struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
-    size_t avail_in = avail_in = strm->avail_in;
+    size_t avail_in = strm->avail_in;
 
     dfltcc(DFLTCC_GDHT,
            param, NULL, NULL,
Signature · 1 line
2.26.3
Acked-by on v1 1/1
#1 lore raw
Quoted 25 lines · Tom Rix

cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
    size_t avail_in = avail_in = strm->avail_in;

Only setting avail_in once is needed.

Fixes aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel

zlib_deflate")

---
 lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
lib/zlib_dfltcc/dfltcc_deflate.c +1 -1
index 80924f067c24..b732b6d9e35d 100644
@@ -62,7 +62,7 @@ static void dfltcc_gdht(
  {
      deflate_state *state = (deflate_state *)strm->state;
      struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
-    size_t avail_in = avail_in = strm->avail_in;
+    size_t avail_in = strm->avail_in;
Quoted 3 lines


     dfltcc(DFLTCC_GDHT,
            param, NULL, NULL,

Thanks for spotting this!

Acked-by on v1 1/1
#2 lore raw
In reply to Tom Rix
Quoted 17 lines · Tom Rix

cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]

    size_t avail_in = avail_in = strm->avail_in;

Only setting avail_in once is needed.

Fixes aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
---
 lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/zlib_dfltcc/dfltcc_deflate.c +0 -0
index 80924f067c24..b732b6d9e35d 100644

lib/zlib_dfltcc/dfltcc_deflate.c static void dfltcc_gdht( · line 68

Quoted 8 lines
lib/zlib_dfltcc/dfltcc_deflate.c +1 -1
@@ -62,7 +62,7 @@ static void dfltcc_gdht(
 {
     deflate_state *state = (deflate_state *)strm->state;
     struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
-    size_t avail_in = avail_in = strm->avail_in;
+    size_t avail_in = strm->avail_in;
 
     dfltcc(DFLTCC_GDHT,
            param, NULL, NULL,