lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()
PATCH 1/1 lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()
cppcheck reportslib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
size_t avail_in = avail_in = strm->avail_in;
Only setting avail_in once is needed.
--- lib/zlib_dfltcc/dfltcc_deflate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/zlib_dfltcc/dfltcc_deflate.c +1 -1
@@ -62,7 +62,7 @@ static void dfltcc_gdht( {deflate_state *state = (deflate_state *)strm->state;struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE (state)->param; -size_t avail_in = avail_in = strm->avail_in; +size_t avail_in = strm->avail_in; dfltcc(DFLTCC_GDHT, param, NULL, NULL,
Signature · 1 line
2.26.3
Quoted 25 lines · Tom Rix
cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
size_tavail_in=avail_in=strm->avail_in;Only setting
avail_inonce is needed.Fixes aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel
zlib_deflate")Signed-off-by Tom Rix <[email protected]>---
lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)lib/zlib_dfltcc/dfltcc_deflate.c +1
-1@@ -62,7 +62,7 @@ static void dfltcc_gdht( { deflate_state *state = (deflate_state *)strm->state; struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param; - size_t avail_in = avail_in = strm->avail_in; + size_t avail_in = strm->avail_in;
Quoted 3 lines
dfltcc(DFLTCC_GDHT,
param, NULL, NULL,
Thanks for spotting this!
Quoted 17 lines · Tom Rix
cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]size_t avail_in = avail_in = strm->avail_in;Only setting
avail_inonce is needed.Fixes aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")Signed-off-by Tom Rix <[email protected]>--- lib/zlib_dfltcc/dfltcc_deflate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/zlib_dfltcc/dfltcc_deflate.c +0
-0
lib/zlib_dfltcc/dfltcc_deflate.c static void dfltcc_gdht( · line 68
Quoted 8 lines
lib/zlib_dfltcc/dfltcc_deflate.c +1
-1@@ -62,7 +62,7 @@ static void dfltcc_gdht( {deflate_state *state = (deflate_state *)strm->state;struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE (state)->param; -size_t avail_in = avail_in = strm->avail_in; +size_t avail_in = strm->avail_in; dfltcc(DFLTCC_GDHT, param, NULL, NULL,