Skip to contentSkip to conversation

dt-bindings: mmc: Add cap-aggressive-pm property

PATCH In review Hermes Zhang 3 participants 3 messages Jan 30, 2023 – Jan 31, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: mmc: Add cap-aggressive-pm property

Add a new property: cap-aggressive-pm to enable the MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

---

Notes:
Update commit message

 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +5 -0
index 86c73fd825fd..7ca674263dba 100644
@@ -177,6 +177,11 @@ properties:
     description:
       enable SDIO IRQ signalling on this interface
 
+  cap-aggressive-pm:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      enable MMC_CAP_AGGRESSIVE_PM feature
+
   full-pwr-cycle:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
Signature · 1 line
2.30.2
maintainer
#1 lore raw
Quoted 2 lines · Hermes Zhang

Add a new property: cap-aggressive-pm to enable the MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Is that a kernel feature or something from the MMC or SD specifications? The former doesn't belong in DT. Set this based on the compatible string of the controller.

Quoted 29 lines

---

Notes:
Update commit message

 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +5 -0
index 86c73fd825fd..7ca674263dba 100644
@@ -177,6 +177,11 @@ properties:
     description:
       enable SDIO IRQ signalling on this interface
 
+  cap-aggressive-pm:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      enable MMC_CAP_AGGRESSIVE_PM feature
+
   full-pwr-cycle:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
Signature · 1 line
2.30.2
#2 lore raw
In reply to Hermes Zhang
Quoted 4 lines · Hermes Zhang

Add a new property: cap-aggressive-pm to enable the MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

We did not finish discussion from v1 as you did not really answer my concerns there. Don't send v2 because it looks like you cut the discussion and ignore the feedback.

Best regards,
Krzysztof