Skip to contentSkip to conversation

tracing: clean up some inconsistent indentings

PATCH NAK Yang Li 2 participants 2 messages Jan 31, 2023 Tracing

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 tracing: clean up some inconsistent indentings

kernel/trace/trace_events_synth.c:567 trace_event_raw_event_synth() warn: inconsistent indenting

---
 kernel/trace/trace_events_synth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/trace/trace_events_synth.c +2 -1
index adb630633f31..949d4cbe3f82 100644
@@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data,
 					   event->fields[i]->is_dynamic,
 					   data_size, &n_u64);
 			data_size += len; /* only dynamic string increments */
-		} if (event->fields[i]->is_stack) {
+		}
+		if (event->fields[i]->is_stack) {
 		        long *stack = (long *)(long)var_ref_vals[val_idx];
 
 			len = trace_stack(entry, event, stack,
Signature · 1 line
2.20.1.7.g153144c
maintainer NAK
#1 lore raw
Quoted 2 lines · On Tue, 31 Jan 2023 14:19:35 +0800 Yang Li <[email protected]> wrote:

kernel/trace/trace_events_synth.c:567 trace_event_raw_event_synth() warn: inconsistent indenting

NACK!

This just removes the warning and hence it hides the bug!

This was already reported by kernel test robot:
https://lore.kernel.org/all/[email protected]/

I have a fix but haven't posted it yet.

-- Steve

Quoted 21 lines
---
 kernel/trace/trace_events_synth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/trace/trace_events_synth.c +2 -1
index adb630633f31..949d4cbe3f82 100644
@@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data,
 					   event->fields[i]->is_dynamic,
 					   data_size, &n_u64);
 			data_size += len; /* only dynamic string increments */
-		} if (event->fields[i]->is_stack) {
+		}
+		if (event->fields[i]->is_stack) {
 		        long *stack = (long *)(long)var_ref_vals[val_idx];
 
 			len = trace_stack(entry, event, stack,