tracing: clean up some inconsistent indentings
PATCH 1/1 tracing: clean up some inconsistent indentings
kernel/trace/trace_events_synth.c:567 trace_event_raw_event_synth() warn: inconsistent indenting
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- kernel/trace/trace_events_synth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/trace/trace_events_synth.c +2 -1
@@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data, event->fields[i]->is_dynamic, data_size, &n_u64); data_size += len;/* only dynamic string increments */ - }if (event->fields[i]->is_stack) { + } +if (event->fields[i]->is_stack) {long *stack = (long *)(long )var_ref_vals[val_idx]; len = trace_stack(entry, event, stack,
Signature · 1 line
2.20.1.7.g153144c
Quoted 2 lines · On Tue, 31 Jan 2023 14:19:35 +0800 Yang Li <[email protected]> wrote:
kernel/trace/trace_events_synth.c:567trace_event_raw_event_synth()warn: inconsistent indenting
NACK!
This just removes the warning and hence it hides the bug!
This was already reported by kernel test robot:
https://lore.kernel.org/all/[email protected]/
I have a fix but haven't posted it yet.
-- Steve
Quoted 21 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- kernel/trace/trace_events_synth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)kernel/trace/trace_events_synth.c +2
-1@@ -564,7 +564,8 @@ static notrace void trace_event_raw_event_synth(void *__data, event->fields[i]->is_dynamic, data_size, &n_u64); data_size += len;/* only dynamic string increments */ - }if (event->fields[i]->is_stack) { + } +if (event->fields[i]->is_stack) {long *stack = (long *)(long )var_ref_vals[val_idx]; len = trace_stack(entry, event, stack,