Skip to contentSkip to conversation

ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

PATCH Superseded Mario Limonciello 2 participants 6 messages Feb 13, 2023 – Feb 14, 2023 ACPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 for StorageD3Enable") introduced a quirk to allow a system with ambiguous use of _ADR 0 to force StorageD3Enable.

David Alvarez Lombardi reports that Inspiron 14 5425 suffers that same symptoms. Add this other system to the list as well.

---
 drivers/acpi/x86/utils.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/x86/utils.c +7 -0
index d7d3f1669d4c0..3409ce6513afa 100644
@@ -213,12 +213,19 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
 		 * _ADR is ambiguous between GPP1.DEV0 and GPP1.NVME
 		 * but .NVME is needed to get StorageD3Enable node
 		 * https://bugzilla.kernel.org/show_bug.cgi?id=216440
+		 * https://bugzilla.kernel.org/show_bug.cgi?id=216773
 		 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
 		}
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 5425"),
+		}
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 for StorageD3Enable") introduced a quirk to allow a system with ambiguous use of _ADR 0 to force StorageD3Enable.

It is reported that Vostro 5626 suffers same symptoms. Add this other system to the list as well.

---
 drivers/acpi/x86/utils.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/x86/utils.c +7 -0
index 3409ce6513afa..b1d24718f73d7 100644
@@ -214,6 +214,7 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
 		 * but .NVME is needed to get StorageD3Enable node
 		 * https://bugzilla.kernel.org/show_bug.cgi?id=216440
 		 * https://bugzilla.kernel.org/show_bug.cgi?id=216773
+		 * https://bugzilla.kernel.org/show_bug.cgi?id=217003
 		 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
@@ -232,6 +233,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
 		}
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5625"),
+		}
+	},
 	{}
 };
 
Signature · 1 line
2.34.1
#2 lore raw
Quoted 11 lines · Mario Limonciello

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 for StorageD3Enable") introduced a quirk to allow a system with ambiguous use of _ADR 0 to force StorageD3Enable.

It is reported that Vostro 5626 suffers same symptoms. Add this other system to the list as well.

Can you please combine these two patches into one?

Or at least make the subjects differ?

Quoted 32 lines
---
 drivers/acpi/x86/utils.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/x86/utils.c +7 -1
index 3409ce6513afa..b1d24718f73d7 100644
@@ -214,6 +214,7 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
                 * but .NVME is needed to get StorageD3Enable node
                 * https://bugzilla.kernel.org/show_bug.cgi?id=216440
                 * https://bugzilla.kernel.org/show_bug.cgi?id=216773
+                * https://bugzilla.kernel.org/show_bug.cgi?id=217003
                 */
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
@@ -232,6 +233,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
                        DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
                }
        },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5625"),
+               }
+       },
        {}
 };
 
--

2.34.1

#3 lore raw

[AMD Official Use Only - General]

Quoted 19 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Tuesday, February 14, 2023 08:49
To: Limonciello, Mario <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Len Brown <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

Quoted 8 lines · Mario Limonciello

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 for StorageD3Enable") introduced a quirk to allow a system with ambiguous use of _ADR 0 to force StorageD3Enable.

It is reported that Vostro 5626 suffers same symptoms. Add this other system to the list as well.

Quoted 7 lines
Quoted 3 lines

Can you please combine these two patches into one?

Or at least make the subjects differ?

I left them split so that we could revert one if the BIOS is fixed on one in the future. Happy to respin with separate subjects.

But before I respin; something else I want to offer as an idea to avoid this list growing.

They all use the same CPU. So we could just add the CPU model that all of these use to the force StorageD3Enable list and take out the whole (growing) list.

Which way would you prefer?

Quoted 35 lines

drivers/acpi/x86/utils.c static const struct dmi_system_id

Quoted 10 lines
---
 drivers/acpi/x86/utils.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/acpi/x86/utils.c +0 -0
index 3409ce6513afa..b1d24718f73d7 100644
@@ -214,6 +214,7 @@ static const struct dmi_system_id

force_storage_d3_dmi[] = {

drivers/acpi/x86/utils.c static const struct dmi_system_id

Quoted 8 lines
drivers/acpi/x86/utils.c +1 -0
                 * but .NVME is needed to get StorageD3Enable node
                 * https://bugzilla.kernel.org/show_bug.cgi?id=216440
                 * https://bugzilla.kernel.org/show_bug.cgi?id=216773
+                * https://bugzilla.kernel.org/show_bug.cgi?id=217003
                 */
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
@@ -232,6 +233,12 @@ static const struct dmi_system_id

force_storage_d3_dmi[] = {

Quoted 15 lines
drivers/acpi/x86/utils.c +6 -1
                        DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
                }
        },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 5625"),
+               }
+       },
        {}
 };
 
--

2.34.1

#4 lore raw
Quoted 32 lines · Mario

[AMD Official Use Only - General]

Quoted 19 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Tuesday, February 14, 2023 08:49
To: Limonciello, Mario <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Len Brown <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

Quoted 8 lines · Mario Limonciello

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1 for StorageD3Enable") introduced a quirk to allow a system with ambiguous use of _ADR 0 to force StorageD3Enable.

It is reported that Vostro 5626 suffers same symptoms. Add this other system to the list as well.

Quoted 7 lines
Quoted 3 lines

Can you please combine these two patches into one?

Or at least make the subjects differ?

Quoted 8 lines

I left them split so that we could revert one if the BIOS is fixed on one in the future. Happy to respin with separate subjects.

But before I respin; something else I want to offer as an idea to avoid this list growing.

They all use the same CPU. So we could just add the CPU model that all of these use to the force StorageD3Enable list and take out the whole (growing) list.

Well, I'd rather do this, but in the next cycle.

Quoted 1 line

Which way would you prefer?

For this merge window, please respin the current patch series and make the changes as per the above early after 6.3-rc1.

It may be still necessary to pull them into 6.3-rc later, if more instances are reported or discovered, but we'll see.

#5 lore raw

[AMD Official Use Only - General]

Quoted 60 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Tuesday, February 14, 2023 08:59
To: Limonciello, Mario <[email protected]>
Cc: Rafael J. Wysocki <[email protected]>; [email protected]; [email protected]; Len Brown <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for forcing StorageD3Enable

Quoted 10 lines · Mario

[AMD Official Use Only - General]

Quoted 5 lines

-----Original Message-----
From: Rafael J. Wysocki <[email protected]>
Sent: Tuesday, February 14, 2023 08:49
To: Limonciello, Mario <[email protected]>
Cc: [email protected]; [email protected]; [email protected];

Len

Quoted 2 lines
Quoted 2 lines

Brown <[email protected]>; [email protected]
Subject: Re: [PATCH 2/2] ACPI: x86: Add more systems to quirk list for

forcing

Quoted 6 lines
Quoted 6 lines

StorageD3Enable

Quoted 2 lines · Mario Limonciello

commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-

1

Quoted 1 line
Quoted 1 line
Quoted 1 line

for StorageD3Enable") introduced a quirk to allow a system with

ambiguous

Quoted 9 lines
Quoted 9 lines
Quoted 8 lines

use of _ADR 0 to force StorageD3Enable.

It is reported that Vostro 5626 suffers same symptoms. Add this other system to the list as well.

Quoted 8 lines
Quoted 3 lines

Can you please combine these two patches into one?

Or at least make the subjects differ?

I left them split so that we could revert one if the BIOS is fixed on one in the future. Happy to respin with separate subjects.

But before I respin; something else I want to offer as an idea to avoid this

list

Quoted 3 lines

growing.

They all use the same CPU. So we could just add the CPU model that all of

these

Quoted 1 line

use to the force StorageD3Enable list and take out the whole (growing) list.

Well, I'd rather do this, but in the next cycle.

Quoted 7 lines
Quoted 1 line

Which way would you prefer?

For this merge window, please respin the current patch series and make the changes as per the above early after 6.3-rc1.

It may be still necessary to pull them into 6.3-rc later, if more instances are reported or discovered, but we'll see.

Sure, thanks. I'll rework it for this and wait until 6.3-rc1 to send it.