Skip to contentSkip to conversation

gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx

PATCH In review Werner Sembach 2 participants 2 messages Feb 15, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx

commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable") changed the policy such that I2C touchpads may be able to wake up the system by default if the system is configured as such.

However for some devices there is a bug, that is causing the touchpad to instantly wake up the device again once it gets deactivated. The root cause is still under investigation:
https://lore.kernel.org/linux-acpi/[email protected]/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d

To workaround this problem for the time being, introduce a quirk for this model that will prevent the wakeup capability for being set for GPIO 16.

---
 drivers/gpio/gpiolib-acpi.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
drivers/gpio/gpiolib-acpi.c +12 -0
index e2ab4d5253bea..82e8e43582eba 100644
@@ -1612,6 +1612,18 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
 			.ignore_wake = "ELAN0415:00@9",
 		},
 	},
+	{
+		/*
+		 * Spurious wakeups from TP_ATTN# pin
+		 * Found in BIOS 1.7.7
+		 */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "NH5xAx"),
+		},
+		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+			.ignore_wake = "SYNA1202:00@16",
+		},
+	},
 	{} /* Terminating entry */
 };
 
Signature · 1 line
2.34.1
#1 lore raw
Quoted 11 lines · Werner Sembach

commit 1796f808e4bb ("HID: i2c-hid: acpi: Stop setting wakeup_capable") changed the policy such that I2C touchpads may be able to wake up the system by default if the system is configured as such.

However for some devices there is a bug, that is causing the touchpad to instantly wake up the device again once it gets deactivated. The root cause is still under investigation:
https://lore.kernel.org/linux-acpi/[email protected]/T/#mb2e738787f6b6208d17b92aa6e72d4de846d4e4d

To workaround this problem for the time being, introduce a quirk for this model that will prevent the wakeup capability for being set for GPIO 16.

I massaged a bit the commit message and pushed for fixes, thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko