ALSA: ppc/tumbler: Use of_property_present() for testing DT property presence
PATCH 1/1 ALSA: ppc/tumbler: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.
--- sound/ppc/tumbler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/ppc/tumbler.c +1 -1
@@ -1363,7 +1363,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)if (of_node_name_eq (np,"sound" )) {if (of_get_property (np,"has-anded-reset" ,NULL )) mix->anded_reset =1 ; -if (of_get_property (np,"layout-id" ,NULL )) +if (of_property_present (np,"layout-id" )) mix->reset_on_sleep =0 ;of_node_put (np);break ;
Signature · 1 line
2.39.2
Quoted 9 lines · Rob Herring
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added
of_property_present()helper when we just want to test for presence of a property and nothing more.Signed-off-by Rob Herring <[email protected]>
Applied now to for-next branch.
thanks,
Takashi