Skip to contentSkip to conversation

ALSA: ppc/tumbler: Use of_property_present() for testing DT property presence

PATCH In review Rob Herring 2 participants 2 messages Mar 10, 2023 – Apr 19, 2023 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: ppc/tumbler: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

---
 sound/ppc/tumbler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/ppc/tumbler.c +1 -1
index f3f8ad7c3df8..6c882873b344 100644
@@ -1363,7 +1363,7 @@ int snd_pmac_tumbler_init(struct snd_pmac *chip)
 		if (of_node_name_eq(np, "sound")) {
 			if (of_get_property(np, "has-anded-reset", NULL))
 				mix->anded_reset = 1;
-			if (of_get_property(np, "layout-id", NULL))
+			if (of_property_present(np, "layout-id"))
 				mix->reset_on_sleep = 0;
 			of_node_put(np);
 			break;
Signature · 1 line
2.39.2
#1 lore raw
Quoted 9 lines · Rob Herring

It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more.

Applied now to for-next branch.

thanks,

Takashi