Skip to contentSkip to conversation

ASoC: dt-bindings: adi,adau17x1: Convert to DT schema

RFC PATCH Superseded Vijaya Anand 2 participants 2 messages Mar 15, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/1 ASoC: dt-bindings: adi,adau17x1: Convert to DT schema

Convert the binding document for adi,adau17x1 from txt to yaml so one could validate dt-entries correctly and any future additions can go into yaml format. Add address and size cells to example to prevent errors regarding reg format.

---
Changes since v1:
- added 'Codec' in title to clarify type of devices
- put compatible devices in lexographic order
- changed description of clocks
- changed 'unevaluatedProperties' to 'additionalProperties'
- changed node names to be generic

---
 .../bindings/sound/adi,adau17x1.txt           | 32 ------------
 .../bindings/sound/adi,adau17x1.yaml          | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 32 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.txt
 create mode 100644 Documentation/devicetree/bindings/sound/adi,adau17x1.yaml
Documentation/devicetree/bindings/sound/adi,adau17x1.txt deleted +0 -32
deleted file mode 100644
index 1447dec28125..000000000000
@@ -1,32 +0,0 @@
-Analog Devices ADAU1361/ADAU1461/ADAU1761/ADAU1961/ADAU1381/ADAU1781
-
-Required properties:
-
- - compatible:		Should contain one of the following:
-			"adi,adau1361"
-			"adi,adau1461"
-			"adi,adau1761"
-			"adi,adau1961"
-			"adi,adau1381"
-			"adi,adau1781"
-
- - reg:			The i2c address. Value depends on the state of ADDR0
-			and ADDR1, as wired in hardware.
-
-Optional properties:
- - clock-names:		If provided must be "mclk".
- - clocks:		phandle + clock-specifiers for the clock that provides
-			the audio master clock for the device.
-
-Examples:
-#include <dt-bindings/sound/adau17x1.h>
-
-	i2c_bus {
-		adau1361@38 {
-			compatible = "adi,adau1761";
-			reg = <0x38>;
-
-			clock-names = "mclk";
-			clocks = <&audio_clock>;
-		};
-	};
Documentation/devicetree/bindings/sound/adi,adau17x1.yaml new file +52 -0

52 lines not on this page · raw message

+ };

Signature · 1 line
2.37.1 (Apple Git-137.1)
#1 lore raw
Quoted 4 lines · Vijaya Anand

Convert the binding document for adi,adau17x1 from txt to yaml so one could validate dt-entries correctly and any future additions can go into yaml format. Add address and size cells to example to prevent errors regarding reg format.

Why this is still RFC? RFC means it is not ready for applying, not full review, just some glance and comments. Some maintainers will not apply RFC patches at all. What do you question here?

Quoted 10 lines

---
Changes since v1:
- added 'Codec' in title to clarify type of devices
- put compatible devices in lexographic order
- changed description of clocks
- changed 'unevaluatedProperties' to 'additionalProperties'
- changed node names to be generic

Best regards,
Krzysztof