Skip to contentSkip to conversation

ASoC: dt-bindings: ak4458: Convert to dtschema

PATCH Superseded Saalim Quadri 2 participants 2 messages Mar 27, 2023 – Mar 28, 2023

Subsystems (2)
Device tree bindings ASoC

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Saalim Quadri

author
#0 lore raw

PATCH v3 1/1 ASoC: dt-bindings: ak4458: Convert to dtschema

Convert the AK4458 audio DAC bindings to DT schema.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 -> V2: Use the correct way for dsd-path property
Drop ak4458 label form example
V2 -> V3: ak4458 is the only one that does not support dsd-path, so we
do not require to define an array

 .../devicetree/bindings/sound/ak4458.txt      | 28 --------
 .../bindings/sound/asahi-kasei,ak4458.yaml    | 65 +++++++++++++++++++
 2 files changed, 65 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
Documentation/devicetree/bindings/sound/ak4458.txt deleted +0 -28
deleted file mode 100644
index 0416c14895d6..000000000000
@@ -1,28 +0,0 @@
-AK4458 audio DAC
-
-This device supports I2C mode.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak4458" or "asahi-kasei,ak4497"
-- reg : The I2C address of the device for I2C
-
-Optional properties:
-- reset-gpios: A GPIO specifier for the power down & reset pin
-- mute-gpios: A GPIO specifier for the soft mute pin
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-- dsd-path: Select DSD input pins for ak4497
-            0: select #16, #17, #19 pins
-            1: select #3, #4, #5 pins
-
-Example:
-
-&i2c {
-	ak4458: dac@10 {
-		compatible = "asahi-kasei,ak4458";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>
-		mute-gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>
-	};
-};
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +65 -0

65 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 79 lines · Saalim Quadri

Convert the AK4458 audio DAC bindings to DT schema.

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 -> V2: Use the correct way for dsd-path property
Drop ak4458 label form example
V2 -> V3: ak4458 is the only one that does not support dsd-path, so we
do not require to define an array

 .../devicetree/bindings/sound/ak4458.txt      | 28 --------
 .../bindings/sound/asahi-kasei,ak4458.yaml    | 65 +++++++++++++++++++
 2 files changed, 65 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
Documentation/devicetree/bindings/sound/ak4458.txt deleted +0 -28
deleted file mode 100644
index 0416c14895d6..000000000000
@@ -1,28 +0,0 @@
-AK4458 audio DAC
-
-This device supports I2C mode.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak4458" or "asahi-kasei,ak4497"
-- reg : The I2C address of the device for I2C
-
-Optional properties:
-- reset-gpios: A GPIO specifier for the power down & reset pin
-- mute-gpios: A GPIO specifier for the soft mute pin
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-- dsd-path: Select DSD input pins for ak4497
-            0: select #16, #17, #19 pins
-            1: select #3, #4, #5 pins
-
-Example:
-
-&i2c {
-	ak4458: dac@10 {
-		compatible = "asahi-kasei,ak4458";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>
-		mute-gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>
-	};
-};
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +23 -0
new file mode 100644
index 000000000000..3842e75d9921
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4458.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AK4458 audio DAC
+
+maintainers:
+  - Shengjiu Wang <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - asahi-kasei,ak4458
+      - asahi-kasei,ak4497
+
+  reg:
+    maxItems: 1
+
+  avdd-supply:
+    description: Analog power supply
+

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 33

Quoted 10 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +10 -0
+  dvdd-supply:
+    description: Digital power supply
+
+  reset-gpios:
+    maxItems: 1
+
+  mute-gpios:
+    maxItems: 1
+    description:
+      GPIO used to mute all the outputs

What happened to dsd-path? Do not remove properties from the bindings without some valid reason.

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 41

Quoted 8 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +8 -0
+
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const:
+              asahi-kasei,ak4458

This is one line - const: foo bar

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 46

Quoted 5 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +5 -0
+
+    then:
+      properties:
+        dsd-path: false
+

Best regards,
Krzysztof