Skip to contentSkip to conversation

ASoC: dt-bindings: ak4458: Convert to dtschema

PATCH Superseded Saalim Quadri 2 participants 5 messages Mar 25, 2023 – Mar 26, 2023

Subsystems (2)
Device tree bindings ASoC

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Saalim Quadri

author
#0 lore raw

PATCH 1/1 ASoC: dt-bindings: ak4458: Convert to dtschema

Convert the AK4458 audio DAC bindings to DT schema.

Signed-off-by Saalim Quadri <[email protected]>
---
 .../devicetree/bindings/sound/ak4458.txt      | 28 ---------
 .../bindings/sound/asahi-kasei,ak4458.yaml    | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
Documentation/devicetree/bindings/sound/ak4458.txt deleted +0 -28
deleted file mode 100644
index 0416c14895d6..000000000000
@@ -1,28 +0,0 @@
-AK4458 audio DAC
-
-This device supports I2C mode.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak4458" or "asahi-kasei,ak4497"
-- reg : The I2C address of the device for I2C
-
-Optional properties:
-- reset-gpios: A GPIO specifier for the power down & reset pin
-- mute-gpios: A GPIO specifier for the soft mute pin
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-- dsd-path: Select DSD input pins for ak4497
-            0: select #16, #17, #19 pins
-            1: select #3, #4, #5 pins
-
-Example:
-
-&i2c {
-	ak4458: dac@10 {
-		compatible = "asahi-kasei,ak4458";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>
-		mute-gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>
-	};
-};
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
2.34.1
author
#1 lore raw

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 42

Quoted 8 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +8 -0
+  dsd-path:
+    description: Select DSD input pins for ak4497
+    $ref: /schemas/types.yaml#/definitions/uint32
+    oneOf:
+      - const: 0
+        description: select #16, #17, #19 pins
+      - const: 1
+        description: select #3, #4, #5 pins

I hope if you can review this part correctly.

Thank you,

Saalim

#2 lore raw
In reply to Saalim Quadri
Quoted 87 lines · Saalim Quadri

Convert the AK4458 audio DAC bindings to DT schema.

Signed-off-by Saalim Quadri <[email protected]>
---
 .../devicetree/bindings/sound/ak4458.txt      | 28 ---------
 .../bindings/sound/asahi-kasei,ak4458.yaml    | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak4458.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml
Documentation/devicetree/bindings/sound/ak4458.txt deleted +0 -28
deleted file mode 100644
index 0416c14895d6..000000000000
@@ -1,28 +0,0 @@
-AK4458 audio DAC
-
-This device supports I2C mode.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak4458" or "asahi-kasei,ak4497"
-- reg : The I2C address of the device for I2C
-
-Optional properties:
-- reset-gpios: A GPIO specifier for the power down & reset pin
-- mute-gpios: A GPIO specifier for the soft mute pin
-- AVDD-supply: Analog power supply
-- DVDD-supply: Digital power supply
-- dsd-path: Select DSD input pins for ak4497
-            0: select #16, #17, #19 pins
-            1: select #3, #4, #5 pins
-
-Example:
-
-&i2c {
-	ak4458: dac@10 {
-		compatible = "asahi-kasei,ak4458";
-		reg = <0x10>;
-		reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>
-		mute-gpios = <&gpio1 11 GPIO_ACTIVE_HIGH>
-	};
-};
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +37 -0
new file mode 100644
index 000000000000..b97aee96fa17
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4458.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AK4458 audio DAC
+
+maintainers:
+  - Shengjiu Wang <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - asahi-kasei,ak4458
+      - asahi-kasei,ak4497
+
+  reg:
+    maxItems: 1
+
+  avdd-supply:
+    description: Analog power supply
+
+  dvdd-supply:
+    description: Digital power supply
+
+  reset-gpios:
+    maxItems: 1
+
+  mute-gpios:
+    maxItems: 1
+    description:
+      GPIO used to mute all the outputs
+
+  dsd-path:
+    description: Select DSD input pins for ak4497
+    $ref: /schemas/types.yaml#/definitions/uint32

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 47

Quoted 10 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +10 -0
+    oneOf:
+      - const: 0
+        description: select #16, #17, #19 pins
+      - const: 1
+        description: select #3, #4, #5 pins
+
+required:
+  - compatible
+  - reg
+

Based on driver:

allOf:
- if:
properties:
compatible:
enum:
- ak4458.....
then:
properties:
dsd-path: false

Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml line 49

Quoted 2 lines
Documentation/devicetree/bindings/sound/asahi-kasei,ak4458.yaml new file +2 -0
+additionalProperties: false
+

Best regards,
Krzysztof

author
#3 lore raw
Quoted 9 lines

allOf:
- if:
properties:
compatible:
enum:
- ak4458.....
then:
properties:
dsd-path: false

Do we also require to add a descriptioon to explain the pins which will be selected based off on the value? Or have you disabled it based on, that it is disabled for ak4458 codecs?

Thank you,

Saalim

#4 lore raw
Quoted 11 lines · Saalim Quadri
Quoted 9 lines

allOf:
- if:
properties:
compatible:
enum:
- ak4458.....
then:
properties:
dsd-path: false

Do we also require to add a descriptioon to explain the pins which will be selected based off on the value?

Description where? What pins?

Quoted 1 line

Or have you disabled it based on, that it is disabled for ak4458 codecs?

What is disabled? The driver indicates the property is valid only for ak4497.

Best regards,
Krzysztof