Skip to contentSkip to conversation

ASoC: dt-bindings: wm8510: Convert to dtschema

PATCH Superseded Saalim Quadri 3 participants 4 messages Apr 3, 2023 – Apr 5, 2023

Subsystems (3)
Device tree bindings ASoC Wolfson microelectronics drivers

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Saalim Quadri

author
#0 lore raw

PATCH v2 1/1 ASoC: dt-bindings: wm8510: Convert to dtschema

Convert the WM8510 audio CODEC bindings to DT schema

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: Fixup issues mentioned by Krzysztof
Add SPI and I2C examples

 .../devicetree/bindings/sound/wlf,wm8510.yaml | 52 +++++++++++++++++++
 .../devicetree/bindings/sound/wm8510.txt      | 18 -------
 2 files changed, 52 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +52 -0
new file mode 100644
index 000000000000..418a82f65531
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8510 audio CODEC
+
+maintainers:
+  - [email protected]
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: wlf,wm8510
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        
+        codec@0 {
+            compatible = "wlf,wm8510";
+            reg = <0>;
+        };
+    };
+
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            compatible = "wlf,wm8510";
+            reg = <0x1a>;
+        };
+    };
Documentation/devicetree/bindings/sound/wm8510.txt deleted +0 -18
deleted file mode 100644
index e6b6cc041f89..000000000000
@@ -1,18 +0,0 @@
-WM8510 audio CODEC
-
-This device supports both I2C and SPI (configured with pin strapping
-on the board).
-
-Required properties:
-
-  - compatible : "wlf,wm8510"
-
-  - reg : the I2C address of the device for I2C, the chip select
-          number for SPI.
-
-Example:
-
-wm8510: codec@1a {
-	compatible = "wlf,wm8510";
-	reg = <0x1a>;
-};
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Saalim Quadri

Convert the WM8510 audio CODEC bindings to DT schema

Signed-off-by Saalim Quadri <[email protected]>

---
Changes:
V1 - V2: Fixup issues mentioned by Krzysztof

So what changed?

Quoted 1 line

Add SPI and I2C examples

Why?

Quoted 51 lines
 .../devicetree/bindings/sound/wlf,wm8510.yaml | 52 +++++++++++++++++++
 .../devicetree/bindings/sound/wm8510.txt      | 18 -------
 2 files changed, 52 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8510.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/wm8510.txt
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +38 -0
new file mode 100644
index 000000000000..418a82f65531
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8510 audio CODEC
+
+maintainers:
+  - [email protected]
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: wlf,wm8510
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        
+        codec@0 {
+            compatible = "wlf,wm8510";

Documentation/devicetree/bindings/sound/wlf,wm8510.yaml line 48

Quoted 10 lines
Documentation/devicetree/bindings/sound/wlf,wm8510.yaml new file +10 -0
+            reg = <0>;
+        };
+    };
+
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {

Drop second example. It is the same.

Best regards,
Krzysztof

author
#2 lore raw

Changes from V1 -> V2:

Quoted 7 lines

Added cirrus opensource as the maintainer
Added missing $ref to dai-common.yaml
Dropped I2C and SPI description
Added sound-dai-cells property
Added 'compatible' as the required property
additionalProperties: false -> unevaluatedProperties: false after adding $ref Added SPI example

Kind Regards,

Saalim

maintainer
#3 lore raw
In reply to Saalim Quadri
Quoted 3 lines · Saalim Quadri

Convert the WM8510 audio CODEC bindings to DT schema

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: wm8510: Convert to dtschema

      commit: 72456c24c8357793bacf5e67549db1f8c3fafe11

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark