pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static
Subsystems (2)
PATCH 1/1 pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static
smatch reports drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
'mlxbf3_pmx_funcs' was not declared. Should it be static?
This variable is only used in one file so it should be static.
Signed-off-by Tom Rix <[email protected]>
--- drivers/pinctrl/pinctrl-mlxbf3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-mlxbf3.c +1 -1
@@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = {static const char *const mlxbf3_gpiofunc_group_names[] = {"swctrl" };static const char *const mlxbf3_hwfunc_group_names[] = {"hwctrl" }; -struct pinfunction mlxbf3_pmx_funcs[] = { +static struct pinfunction mlxbf3_pmx_funcs[] = {PINCTRL_PINFUNCTION ("hwfunc" , mlxbf3_hwfunc_group_names,1 ),PINCTRL_PINFUNCTION ("gpiofunc" , mlxbf3_gpiofunc_group_names,1 ), };
Signature · 1 line
2.27.0
Quoted 7 lines · Tom Rix
smatch reports
drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
'mlxbf3_pmx_funcs' was not declared. Should it be static?This variable is only used in one file so it should be static.
Signed-off-by Tom Rix <[email protected]>
Obviously correct so patch applied.
Yours,
Linus Walleij