Skip to contentSkip to conversation

pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static

PATCH In review Tom Rix 2 participants 2 messages Apr 4, 2023

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static

smatch reports drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
'mlxbf3_pmx_funcs' was not declared. Should it be static?

This variable is only used in one file so it should be static.

---
 drivers/pinctrl/pinctrl-mlxbf3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-mlxbf3.c +1 -1
index 3698f7bbd88d..d9944e6a0af9 100644
@@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = {
 static const char * const mlxbf3_gpiofunc_group_names[] = { "swctrl" };
 static const char * const mlxbf3_hwfunc_group_names[]   = { "hwctrl" };
 
-struct pinfunction mlxbf3_pmx_funcs[] = {
+static struct pinfunction mlxbf3_pmx_funcs[] = {
 	PINCTRL_PINFUNCTION("hwfunc", mlxbf3_hwfunc_group_names, 1),
 	PINCTRL_PINFUNCTION("gpiofunc", mlxbf3_gpiofunc_group_names, 1),
 };
Signature · 1 line
2.27.0
#1 lore raw
Quoted 7 lines · Tom Rix

smatch reports drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol
'mlxbf3_pmx_funcs' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Obviously correct so patch applied.

Yours,
Linus Walleij