drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
PATCH 1/1 drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
smatch reports drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?
This variable is only used in one file so should be static.
--- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c +1 -1
@@ -655,7 +655,7 @@ static const struct mdp5_cfg_hw msm8x96_config = { .max_clk = 412500000, }; -const struct mdp5_cfg_hw msm8x76_config = { +static const struct mdp5_cfg_hw msm8x76_config = { .name ="msm8x76" , .mdp = { .count =1 ,
Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
smatch reports
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?This variable is only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>--- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes Dmitry
Dmitry Baryshkov
AppliedQuoted 8 lines · Tom Rix
smatch reports
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?This variable is only used in one file so should be static.
[...]
Applied, thanks!
[1/1] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
https://gitlab.freedesktop.org/lumag/msm/-/commit/d2f762745162
Best regards,
Signature · 1 line
Dmitry Baryshkov <[email protected]>