Skip to contentSkip to conversation

drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static

PATCH Applied Tom Rix 2 participants 3 messages Apr 4, 2023 – Apr 5, 2023

Subsystems (3)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static

smatch reports drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
 drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c +1 -1
index 1f1555aa02d2..2eec2d78f32a 100644
@@ -655,7 +655,7 @@ static const struct mdp5_cfg_hw msm8x96_config = {
 	.max_clk = 412500000,
 };
 
-const struct mdp5_cfg_hw msm8x76_config = {
+static const struct mdp5_cfg_hw msm8x76_config = {
 	.name = "msm8x76",
 	.mdp = {
 		.count = 1,
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Tom Rix

smatch reports drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
  drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes
Dmitry
#2 lore raw
In reply to Tom Rix
Quoted 8 lines · Tom Rix

smatch reports drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?

This variable is only used in one file so should be static.

[...]

Applied, thanks!

[1/1] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static

      https://gitlab.freedesktop.org/lumag/msm/-/commit/d2f762745162

Best regards,

Signature · 1 line
Dmitry Baryshkov <[email protected]>