dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
Subsystems (5)
Rob Herring
maintainerPATCH 1/1 dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.
--- Documentation/devicetree/bindings/net/ethernet-switch.yaml | 4 ++++ Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/ethernet-switch.yaml +4 -0
@@ -40,6 +40,10 @@ patternProperties: type: object description: Ethernet switch ports + required: + - "#address-cells" + - "#size-cells" + oneOf: - required: - ports
Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml +3 -1
@@ -53,7 +53,9 @@ examples: reg = <0x10>; ports { - /* ... */ + #address-cells = <1>; + #size-cells = <0>; + /* ... */ }; }; };
Signature · 1 line
2.39.2
Quoted 7 lines · Rob Herring
The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.
Signed-off-by Rob Herring <[email protected]>---
Quoted 6 lines · Rob Herring
The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.
Signed-off-by Rob Herring <[email protected]>
Signature · 1 line
Florian
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 4 Apr 2023 15:42:13 -0500 you wrote:
The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.
Signed-off-by Rob Herring <[email protected]>[...]
Here is the summary with links:
- dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required
https://git.kernel.org/netdev/net-next/c/c8f1f2e94675
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html