Skip to contentSkip to conversation

dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required

PATCH Applied Rob Herring 4 participants 4 messages Apr 4, 2023 – Apr 6, 2023

Subsystems (5)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required

The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.

---
 Documentation/devicetree/bindings/net/ethernet-switch.yaml   | 4 ++++
 Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/net/ethernet-switch.yaml +4 -0
index a04f8ef744aa..2ceccce6cbd7 100644
@@ -40,6 +40,10 @@ patternProperties:
         type: object
         description: Ethernet switch ports
 
+    required:
+      - "#address-cells"
+      - "#size-cells"
+
 oneOf:
   - required:
       - ports
Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.yaml +3 -1
index d7748dd33199..ad1ff9533697 100644
@@ -53,7 +53,9 @@ examples:
             reg = <0x10>;
 
             ports {
-              /* ... */
+                #address-cells = <1>;
+                #size-cells = <0>;
+                /* ... */
             };
         };
     };
Signature · 1 line
2.39.2
#3 lore raw
In reply to Rob Herring
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 4 Apr 2023 15:42:13 -0500 you wrote:

The schema doesn't allow for a single (unaddressed) ethernet port node nor does a single port switch make much sense. So if there's always multiple child nodes, "#address-cells" and "#size-cells" should be required.

[...]

Here is the summary with links:
- dt-bindings: net: ethernet-switch: Make "#address-cells/#size-cells" required

    https://git.kernel.org/netdev/net-next/c/c8f1f2e94675

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html