docs:remove cxl3 device size
PATCH 1/1 docs:remove cxl3 device size
cxl device typ3 size is read from the memory backend device, removing the size option specified in cxl sample command.
Updating sample command to reflect target architecture as x86_64.
--- docs/system/devices/cxl.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
docs/system/devices/cxl.rst +7 -7
@@ -302,7 +302,7 @@ Example command lines --------------------- A very simple setup with just one directly attached CXL Type 3 device:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-lsa1,share=on,mem-path=/tmp/lsa.raw,size=256M \
@@ -315,7 +315,7 @@ A setup suitable for 4 way interleave. Only one fixed window provided, to enable interleave across 2 CXL host bridges. Each host bridge has 2 CXL Root Ports, with the CXL Type3 device directly attached (no switches).:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem2,share=on,mem-path=/tmp/cxltest2.raw,size=256M \
@@ -339,7 +339,7 @@ the CXL Type3 device directly attached (no switches).:: An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem0,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest1.raw,size=256M \
@@ -354,13 +354,13 @@ An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: -device cxl-rp,port=1,bus=cxl.1,id=root_port1,chassis=0,slot=1 \ -device cxl-upstream,bus=root_port0,id=us0 \ -device cxl-downstream,port=0,bus=us0,id=swport0,chassis=0,slot=4 \ - -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0,size=256M \ + -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0 \ -device cxl-downstream,port=1,bus=us0,id=swport1,chassis=0,slot=5 \ - -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1,size=256M \ + -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1 \ -device cxl-downstream,port=2,bus=us0,id=swport2,chassis=0,slot=6 \ - -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2,size=256M \ + -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2 \ -device cxl-downstream,port=3,bus=us0,id=swport3,chassis=0,slot=7 \ - -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3,size=256M \ + -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3 \ -M cxl-fmw.0.targets.0=cxl.1,cxl-fmw.0.size=4G,cxl-fmw.0.interleave-granularity=4k Kernel Configuration Options
Signature · 1 line
2.34.1
On Wed, 5 Apr 2023 15:57:38 +0530
Raghu H <[email protected]> wrote:
Hi Raghu,
Thanks for tidying this up! (and reporting it in the first place) A few minor comments for v2.
A better title might be
docs/cxl: Remove incorrect CXL type 3 size parameter.
Quoted 1 line
cxl device typ3 size is read from the memory backend device, removing the
cxl-type3 memory size is read directly from the provided memory backed end device. Remove non existent size option.
Quoted 3 lines
size option specified in cxl sample command.
Updating sample command to reflect target architecture as
x86_64.
There are two changes in here. Please split it into two patches and add a minimal cover letter (mostly as it gives a place for people to respond to both of them with tags etc).
Quoted 11 lines
Signed-off-by Raghu H <[email protected]>--- docs/system/devices/cxl.rst | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)docs/system/devices/cxl.rst +0
-0
docs/system/devices/cxl.rst Example command lines · line 305
Quoted 5 lines
docs/system/devices/cxl.rst +1
-1@@ -302,7 +302,7 @@ Example command lines --------------------- A very simple setup with just one directly attached CXL Type 3 device:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \
Minimize the change (and definitely don't tell people to use kvm as that's broken for some usecases - instructions in CXL memory).
+ qemu-system-x86_64 -M q35,cxl=on -m 4G,maxmem=8G,slots=8 \
is probably the right combination (I tidied up the g / G mix whilst touching the line.
Quoted 39 lines
docs/system/devices/cxl.rst +6
-6-object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-lsa1,share=on,mem-path=/tmp/lsa.raw,size=256M \@@ -315,7 +315,7 @@ A setup suitable for 4 way interleave. Only one fixed window provided, to enable interleave across 2 CXL host bridges. Each host bridge has 2 CXL Root Ports, with the CXL Type3 device directly attached (no switches).:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem2,share=on,mem-path=/tmp/cxltest2.raw,size=256M \@@ -339,7 +339,7 @@ the CXL Type3 device directly attached (no switches).:: An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ -object memory-backend-file,id=cxl-mem0,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest1.raw,size=256M \@@ -354,13 +354,13 @@ An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: -device cxl-rp,port=1,bus=cxl.1,id=root_port1,chassis=0,slot=1 \ -device cxl-upstream,bus=root_port0,id=us0 \ -device cxl-downstream,port=0,bus=us0,id=swport0,chassis=0,slot=4 \ - -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0,size=256M \ + -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0 \ -device cxl-downstream,port=1,bus=us0,id=swport1,chassis=0,slot=5 \ - -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1,size=256M \ + -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1 \ -device cxl-downstream,port=2,bus=us0,id=swport2,chassis=0,slot=6 \ - -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2,size=256M \ + -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2 \ -device cxl-downstream,port=3,bus=us0,id=swport3,chassis=0,slot=7 \ - -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3,size=256M \ + -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3 \ -M cxl-fmw.0.targets.0=cxl.1,cxl-fmw.0.size=4G,cxl-fmw.0.interleave-granularity=4k Kernel Configuration Options
cover Update CXL documentation
Thanks Jonathan for quick review/comments on earlier patch, as suggested splitting into two separate patches
https://www.mail-archive.com/[email protected]/msg952999.html
Removed the unsupported size option for cxl-type3 device, Qemu reads the device size directly from the backend memory device config.
Currently the Qemu CXL emulation for AARCH64 is not available and its only supported on x86_64 platform emulations. Removing the incorrect information and populating with supported x86_64 sample command to emulate cxl devices.
The document will be updated when the AARCH64 support is mainlined.
Raghu H (2):
docs/cxl: Remove incorrect CXL type 3 size parameter docs/cxl: Replace unsupported AARCH64 with x86_64
docs/system/devices/cxl.rst | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
base-commit: 7d0334e49111787ae19fbc8d29ff6e7347f0605e
Signature · 1 line
2.34.1
PATCH 1/2 docs/cxl: Remove incorrect CXL type 3 size parameter
cxl-type3 memory size is read directly from the provided memory backed end device. Remove non existent size option
--- docs/system/devices/cxl.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
docs/system/devices/cxl.rst +4 -4
@@ -354,13 +354,13 @@ An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: -device cxl-rp,port=1,bus=cxl.1,id=root_port1,chassis=0,slot=1 \ -device cxl-upstream,bus=root_port0,id=us0 \ -device cxl-downstream,port=0,bus=us0,id=swport0,chassis=0,slot=4 \ - -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0,size=256M \ + -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0 \ -device cxl-downstream,port=1,bus=us0,id=swport1,chassis=0,slot=5 \ - -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1,size=256M \ + -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1 \ -device cxl-downstream,port=2,bus=us0,id=swport2,chassis=0,slot=6 \ - -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2,size=256M \ + -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2 \ -device cxl-downstream,port=3,bus=us0,id=swport3,chassis=0,slot=7 \ - -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3,size=256M \ + -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3 \ -M cxl-fmw.0.targets.0=cxl.1,cxl-fmw.0.size=4G,cxl-fmw.0.interleave-granularity=4k Kernel Configuration Options
Signature · 1 line
2.34.1
PATCH 2/2 docs/cxl: Replace unsupported AARCH64 with x86_64
In reply to Raghu HCurrently Qemu CXL emulation support is not availabe on AARCH64 but its available with qemu x86_64 architecture, updating the document to reflect the supported platform.
--- docs/system/devices/cxl.rst | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
docs/system/devices/cxl.rst +6 -3
@@ -302,7 +302,8 @@ Example command lines --------------------- A very simple setup with just one directly attached CXL Type 3 device:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 \ + -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-lsa1,share=on,mem-path=/tmp/lsa.raw,size=256M \
@@ -315,7 +316,8 @@ A setup suitable for 4 way interleave. Only one fixed window provided, to enable interleave across 2 CXL host bridges. Each host bridge has 2 CXL Root Ports, with the CXL Type3 device directly attached (no switches).:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 \ + -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem2,share=on,mem-path=/tmp/cxltest2.raw,size=256M \
@@ -339,7 +341,8 @@ the CXL Type3 device directly attached (no switches).:: An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -m 4G,slots=8,maxmem=8G -smp 4 \ + -machine type=q35,accel=kvm,nvdimm=on,cxl=on -enable-kvm \ ... -object memory-backend-file,id=cxl-mem0,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest1.raw,size=256M \
Signature · 1 line
2.34.1
cover Update CXL documentation
In reply to Jonathan Cameron viaThanks Jonathan for quick review/comments on earlier patch, as suggested splitting into two separate patches
https://www.mail-archive.com/[email protected]/msg952999.html
Removed the unsupported size option for cxl-type3 device, Qemu reads the device size directly from the backend memory device config.
Currently the Qemu CXL emulation for AARCH64 is not available and its only supported on x86_64 platform emulations. Removing the incorrect information and populating with supported x86_64 sample command to emulate cxl devices.
The document will be updated when the AARCH64 support is mainlined.
Raghu H (2):
docs/cxl: Remove incorrect CXL type 3 size parameter docs/cxl: Replace unsupported AARCH64 with x86_64
docs/system/devices/cxl.rst | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)
base-commit: 7d0334e49111787ae19fbc8d29ff6e7347f0605e
Signature · 1 line
2.34.1
PATCH v2 1/2 docs/cxl: Remove incorrect CXL type 3 size parameter
cxl-type3 memory size is read directly from the provided memory backed end device. Remove non existent size option
--- docs/system/devices/cxl.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
docs/system/devices/cxl.rst +4 -4
@@ -354,13 +354,13 @@ An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: -device cxl-rp,port=1,bus=cxl.1,id=root_port1,chassis=0,slot=1 \ -device cxl-upstream,bus=root_port0,id=us0 \ -device cxl-downstream,port=0,bus=us0,id=swport0,chassis=0,slot=4 \ - -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0,size=256M \ + -device cxl-type3,bus=swport0,memdev=cxl-mem0,lsa=cxl-lsa0,id=cxl-pmem0 \ -device cxl-downstream,port=1,bus=us0,id=swport1,chassis=0,slot=5 \ - -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1,size=256M \ + -device cxl-type3,bus=swport1,memdev=cxl-mem1,lsa=cxl-lsa1,id=cxl-pmem1 \ -device cxl-downstream,port=2,bus=us0,id=swport2,chassis=0,slot=6 \ - -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2,size=256M \ + -device cxl-type3,bus=swport2,memdev=cxl-mem2,lsa=cxl-lsa2,id=cxl-pmem2 \ -device cxl-downstream,port=3,bus=us0,id=swport3,chassis=0,slot=7 \ - -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3,size=256M \ + -device cxl-type3,bus=swport3,memdev=cxl-mem3,lsa=cxl-lsa3,id=cxl-pmem3 \ -M cxl-fmw.0.targets.0=cxl.1,cxl-fmw.0.size=4G,cxl-fmw.0.interleave-granularity=4k Kernel Configuration Options
Signature · 1 line
2.34.1
PATCH v2 2/2 docs/cxl: Replace unsupported AARCH64 with x86_64
In reply to Raghu HCurrently Qemu CXL emulation support is not availabe on AARCH64 but its available with qemu x86_64 architecture, updating the document to reflect the supported platform.
--- docs/system/devices/cxl.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
docs/system/devices/cxl.rst +3 -3
@@ -302,7 +302,7 @@ Example command lines --------------------- A very simple setup with just one directly attached CXL Type 3 device:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -M q35,cxl=on -m 4G,maxmem=8G,slots=8 -smp 4 \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-lsa1,share=on,mem-path=/tmp/lsa.raw,size=256M \
@@ -315,7 +315,7 @@ A setup suitable for 4 way interleave. Only one fixed window provided, to enable interleave across 2 CXL host bridges. Each host bridge has 2 CXL Root Ports, with the CXL Type3 device directly attached (no switches).:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -M q35,cxl=on -m 4G,maxmem=8G,slots=8 -smp 4 \ ... -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem2,share=on,mem-path=/tmp/cxltest2.raw,size=256M \
@@ -339,7 +339,7 @@ the CXL Type3 device directly attached (no switches).:: An example of 4 devices below a switch suitable for 1, 2 or 4 way interleave:: - qemu-system-aarch64 -M virt,gic-version=3,cxl=on -m 4g,maxmem=8G,slots=8 -cpu max \ + qemu-system-x86_64 -M q35,cxl=on -m 4G,maxmem=8G,slots=8 -smp 4 \ ... -object memory-backend-file,id=cxl-mem0,share=on,mem-path=/tmp/cxltest.raw,size=256M \ -object memory-backend-file,id=cxl-mem1,share=on,mem-path=/tmp/cxltest1.raw,size=256M \
Signature · 1 line
2.34.1
Re: [PATCH v1 0/2] Update CXL documentation
In reply to Raghu HQuoted 7 lines · On Thu, 6 Apr 2023 18:58:37 +0530 Raghu H <[email protected]> wrote:
Thanks Jonathan for quick review/comments on earlier patch, as suggested splitting into two separate patches
https://www.mail-archive.com/[email protected]/msg952999.htmlRemoved the unsupported size option for cxl-type3 device, Qemu reads the device size directly from the backend memory device config.
Quoted 6 lines
Currently the Qemu CXL emulation for AARCH64 is not available and its only supported on
x86_64platform emulations. Removing the incorrect information and populating with supportedx86_64sample command to emulate cxl devices.The document will be updated when the AARCH64 support is mainlined.
Both look good to me. No need to rush these in.
I'll queue these up in my local tree (and update gitlab/jic23/qemu sometime later this week) but if anyone wants to pick them directly that's fine too.
Quoted 11 lines
Raghu H (2):
docs/cxl: Remove incorrect CXL type 3 size parameter docs/cxl: Replace unsupported AARCH64 withx86_64docs/system/devices/cxl.rst | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)base-commit:
7d0334e49111787ae19fbc8d29ff6e7347f0605e
Re: [PATCH v1 0/2] Update CXL documentation
Thanks Jonathan! I assume it will be merged sometime later with your other patches in the 8.x version!
Quoted 38 lines · Jonathan Cameron
Quoted 7 lines · On Thu, 6 Apr 2023 18:58:37 +0530 Raghu H <[email protected]> wrote:
Thanks Jonathan for quick review/comments on earlier patch, as suggested splitting into two separate patches
https://www.mail-archive.com/[email protected]/msg952999.htmlRemoved the unsupported size option for cxl-type3 device, Qemu reads the device size directly from the backend memory device config.
Quoted 6 lines
Currently the Qemu CXL emulation for AARCH64 is not available and its only supported on
x86_64platform emulations. Removing the incorrect information and populating with supportedx86_64sample command to emulate cxl devices.The document will be updated when the AARCH64 support is mainlined.
Both look good to me. No need to rush these in.
I'll queue these up in my local tree (and update gitlab/jic23/qemu sometime later this week) but if anyone wants to pick them directly that's fine too.
Reviewed-by Jonathan Cameron <[email protected]>Quoted 11 lines
Raghu H (2):
docs/cxl: Remove incorrect CXL type 3 size parameter docs/cxl: Replace unsupported AARCH64 withx86_64docs/system/devices/cxl.rst | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-)base-commit:
7d0334e49111787ae19fbc8d29ff6e7347f0605e