Skip to contentSkip to conversation

drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static

PATCH Applied Tom Rix 2 participants 2 messages Apr 6, 2023 – Apr 10, 2023

Subsystems (4)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static

smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?

This variable is only used in one file so should be static.

---
 drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c +1 -1
index c52b76610bd2..44082f65de1f 100644
@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
 	.dcc_supported = true,
 };
 
-struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
+static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
 		/*TODO: correct dispclk/dppclk voltage level determination*/
 	.clock_limits = {
 		{
Signature · 1 line
2.27.0
#1 lore raw
Quoted 7 lines · Tom Rix

smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?

This variable is only used in one file so should be static.

Applied, thanks!

Quoted 17 lines
---
  drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c +1 -1
index c52b76610bd2..44082f65de1f 100644
@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
  	.dcc_supported = true,
  };
 
-struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
+static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
  		/*TODO: correct dispclk/dppclk voltage level determination*/
  	.clock_limits = {
  		{
Signature · 1 line
Hamza